Subject: Re: [PATCH 3/5] [FS_ENET] OF-related fixup for FEC and SCC MAC's

From: Vitaly Bordug <[email-masked]>
Date: Mon, 22 Jan 2007 17:04:53 +0300

On Mon, 22 Jan 2007 21:07:01 +1100
Paul Mackerras wrote:

> Vitaly Bordug writes:
> 
> > +#ifndef CONFIG_PPC_MERGE
> >  	FW(fecp, ivec, (fep->interrupt / 2) << 29);
> > -	
> > +#else
> > +	FW(fecp, ivec, (irq_map[fep->interrupt].hwirq / 2) << 29);
> > +#endif
> 
> This would be much cleaner if you use virq_to_hw() and add a
> definition of virq_to_hw to the asm-ppc headers, so that you can avoid
> putting ifdefs in code.
> 
Well, first of all it is netdev stuff(as being in drivers/net) and here for reference only. virq_to_hw approach seems very interesting though...

> Also, it seems a bit bogus to be using the hardware interrupt number
> directly here.
> 
FEC is sort of external and requires such a surgery iirc

> Is it just 82xx that uses this driver, or do other chips (85xx?) use
> it too?
>
It exists on 8560ads (and alike) and mpc8xx (mostly). mpc82xx usually is featuring FCC.
 
--
Thanks, Vitaly