Subject: [PATCH 2.6.21 1/4] ehca: fix improper use of yield with spinlock held

From: Hoang-Nam Nguyen <[email-masked]>
Date: Wed, 24 Jan 2007 00:10:36 +0100

Here is a patch for ehca_cq.c that fixes improper use of yield
with spinlock held.
Thanks
Nam

Signed-off-by: Hoang-Nam Nguyen <[email-masked]>
---

 ehca_cq.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)

diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cq.c infiniband_work/drivers/infiniband/hw/ehca/ehca_cq.c
--- infiniband_orig/drivers/infiniband/hw/ehca/ehca_cq.c	2007-01-19 19:40:32.000000000 +0100
+++ infiniband_work/drivers/infiniband/hw/ehca/ehca_cq.c	2007-01-20 00:15:34.000000000 +0100
@@ -344,8 +344,11 @@ int ehca_destroy_cq(struct ib_cq *cq)
 	unsigned long flags;
 
 	spin_lock_irqsave(&ehca_cq_idr_lock, flags);
-	while (my_cq->nr_callbacks)
+	while (my_cq->nr_callbacks) {
+		spin_unlock_irqrestore(&ehca_cq_idr_lock, flags);
 		yield();
+		spin_lock_irqsave(&ehca_cq_idr_lock, flags);
+	}
 
 	idr_remove(&ehca_cq_idr, my_cq->token);
 	spin_unlock_irqrestore(&ehca_cq_idr_lock, flags);