Subject: Re: [PATCH 2/2] move pSeries nvram code to neutral location

From: Nathan Lynch <[email-masked]>
Date: Wed, 24 Jan 2007 19:04:53 -0600

Segher Boessenkool wrote:
> >Move arch/powerpc/platforms/pseries/nvram.c to
> >arch/powerpc/sysdev/rtas_nvram.c so other platforms with RTAS support
> >for manipulating nvram can use it.
> >
> >Add a RTAS_NVRAM Kconfig option which triggers the build of
> >arch/powerpc/sysdev/rtas_nvram.o.
> >
> >Select RTAS_NVRAM for pSeries and Maple platforms.
> 
> The patch seems to select it for pSeries and iSeries, instead?

Aw crap, evidently damage introduced when rebasing (Kconfig files seem
so fragile in this regard).

> >+config RTAS_NVRAM
> >+	bool
> >+	default n
> 
> No need for "default n", all defaults are "n" by default ;-)

Duh, will fix.

> >--- a/arch/powerpc/platforms/pseries/nvram.c
> >+++ /dev/null
> 
> >--- /dev/null
> >+++ b/arch/powerpc/sysdev/rtas_nvram.c
> 
> You can do a "git diff -M" -- that way, we can see that you're
> not trying to sneak in any changes ;-) (and it makes you patch
> much more legible and smaller, too).

Thanks for the tip, I'll try it that way.