Subject: Re: [PATCH 6/14] ps3: smp interrupt fixes

From: Arnd Bergmann <[email-masked]>
Date: Thu, 25 Jan 2007 07:07:07 +0100

On Thursday 25 January 2007 03:40, Geoff Levand wrote:
> --- ps3-linux-dev.orig/arch/powerpc/platforms/ps3/interrupt.c
> +++ ps3-linux-dev/arch/powerpc/platforms/ps3/interrupt.c
> @@ -317,22 +317,23 @@ struct ps3_bmp {
> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0unsigned long unused_1[3];
> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0unsigned long mask;
> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0unsigned long unused_2[3];
> -=A0=A0=A0=A0=A0=A0=A0} __attribute__ ((packed));
> +=A0=A0=A0=A0=A0=A0=A0} __attribute__ ((aligned (64)));

Is that meant to be a 64 _byte_ alignment? By default, it is
already aligned to 64 bit.
If 64 byte is some magic requirement by the hypervisor, you
might want to make that explicit by using a constant definition
for it.

> --- ps3-linux-dev.orig/arch/powerpc/platforms/ps3/setup.c
> +++ ps3-linux-dev/arch/powerpc/platforms/ps3/setup.c
> @@ -109,6 +109,7 @@ static int __init ps3_probe(void)
> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return 0;
> =A0
> =A0=A0=A0=A0=A0=A0=A0=A0powerpc_firmware_features |=3D FW_FEATURE_PS3_POS=
SIBLE;
> +=A0=A0=A0=A0=A0=A0=A0cur_cpu_spec->cpu_features |=3D CPU_FTR_SMT;
> =A0
> =A0=A0=A0=A0=A0=A0=A0=A0ps3_os_area_init();
> =A0=A0=A0=A0=A0=A0=A0=A0ps3_mm_init();
>=20
CPU_FTRS_CELL already contains CPU_FTR_SMT, why do you need to enable
it explicitly?

	Arnd <><