Subject: Re: [PATCH 10/14] ps3: get firmware version

From: Arnd Bergmann <[email-masked]>
Date: Thu, 25 Jan 2007 07:23:48 +0100

On Thursday 25 January 2007 03:40, Geoff Levand wrote:
> Output the PS3 firmware version to dmesg and /proc/cpuinfo.
> 
> Signed-off-by: Geoff Levand <[email-masked]>
> 
Acked-by: Arnd Bergmann <[email-masked]>

I agree with benh that you should avoid the copy of individual fields
inside of the struct ps3_firmware_version, since you can directly
read into a 

struct ps3_firmware_version {
	u16 pad;
	u16 major;
	u16 minor;
	u16 rev;
};