Subject: Re: [patch 1/1] updated version, fixed the compiler warning

From: Christian Krafft <[email-masked]>
Date: Thu, 25 Jan 2007 11:45:15 +1100

Hi,

I just recognized, that the forward declaration is in the tree, so I'll sen=
d an updated version with the cleanup call.

Tschuss,
ck

On Thu, 25 Jan 2007 01:29:48 +0100
Segher Boessenkool <[email-masked]> wrote:

> >> +static int __devexit ipmi_of_remove(struct of_device *dev)
> >> +{
> >> +	/* should call
> >> +	 * cleanup_one_si(dev->dev.driver_data); */
> >> +	return 0;
> >> +}
> >
> > If your remove doesn't work, don't implement one.
>=20
> As explained before, it's the underlying thing that doesn't
> work.  Yeah someone should fix it one day.  Still it's better
> to have this comment than to not have anything at all.  An
> XXX FIXME: tag wouldn't be out of place of course.
>=20
> > Though since you don't
> > have the choice in having a module_exit or not, you should really
> > implement one that works :-)
>=20
> Genau.
>=20
>=20
> Segher
>=20

--=20
Mit freundlichen Gr=FCssen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,=20
Linux Kernel Development
IT Specialist