Subject: Re: [PATCH 1/14] ps3: repository misc fixes

From: Christoph Hellwig <[email-masked]>
Date: Fri, 26 Jan 2007 03:57:41 +0100

On Wed, Jan 24, 2007 at 06:39:37PM -0800, Geoff Levand wrote:
> +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_id);

> +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_type);

> +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_num_dev);

> +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_id);

> +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_type);

> +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_intr);

> +EXPORT_SYMBOL_GPL(ps3_repository_find_device);

> +EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_info);

> +EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_region);

Exporting all these as procedural interfaces is very wrong.  Please
implement a proper bustype for your hypervisor devices where all this
information is an attribute of the hv1_device object.