From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: Christian@ozlabs•org, Paul Mackerras <paulus@samba•org>,
Christian Krafft <krafft@de•ibm.com>,
openipmi-developer@lists•sourceforge.net,
Krafft <krafft@linux•vnet.ibm.com>
Subject: Re: [patch 1/1] updated version, fixed the compiler warning
Date: Fri, 26 Jan 2007 05:23:02 +0100 [thread overview]
Message-ID: <200701260523.04229.arnd@arndb.de> (raw)
In-Reply-To: <20070126025431.GC18537@lst.de>
On Friday 26 January 2007 03:54, Christoph Hellwig wrote:
> > =A0
> > +#ifdef CONFIG_PPC_OF
> > +#include <asm/of_device.h>
> > +#include <asm/of_platform.h>
> > +#endif
>=20
> Adding this OF-specific code to the generic file doesn't look exactly
> nice. =A0Is it possible to separate the code out to a separate ipmi_of.c
> file?
This file already contains the same code for a number of other bus
layers, it might be possible to split out the of part, but then we
should also have separate files for ACPI, PCI and all the others.
I think that reworking the ipmi layer is outside of the scope of
what we want right now, that can be another patch if there is
a consensus that it would be a good idea.
> > +static int __devexit ipmi_of_remove(struct of_device *dev)
> > +{
> > +=A0=A0=A0=A0=A0/* should call
> > +=A0=A0=A0=A0=A0 * cleanup_one_si(dev->dev.driver_data); */
>=20
> Wo why doesn't it do that currently?=20
This mimics the pci driver that also doesn't do it. The comment
is a hint that when it the ipmi driver gets cleaned up so
that _pci gets it right, _of should do the same. That should
also be a separate patch.
Arnd <><
next prev parent reply other threads:[~2007-01-26 4:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061218163846.337fed65@localhost>
2006-12-18 15:42 ` [patch 0/1] ipmi: update: add autosensing of ipmi devices on powerpc using of device tree Christian Krafft
2006-12-18 21:52 ` Segher Boessenkool
2006-12-18 22:23 ` Arnd Bergmann
2006-12-19 17:48 ` Segher Boessenkool
2006-12-19 18:06 ` [Openipmi-developer] " Corey Minyard
2006-12-19 13:12 ` Christian Krafft
2006-12-19 17:52 ` Segher Boessenkool
2006-12-19 18:01 ` Corey Minyard
2006-12-20 14:45 ` [patch 0/1] updated version Christian Krafft
2006-12-21 0:11 ` Arnd Bergmann
2007-01-24 23:45 ` [patch 1/1] updated version, fixed the compiler warning Christian Krafft
2007-01-24 23:56 ` Benjamin Herrenschmidt
2007-01-25 0:29 ` Segher Boessenkool
2007-01-25 0:45 ` Christian Krafft
2007-01-25 0:45 ` Benjamin Herrenschmidt
2007-01-25 1:05 ` Segher Boessenkool
2007-01-25 3:14 ` Arnd Bergmann
2007-01-25 0:24 ` Segher Boessenkool
2007-01-25 3:30 ` [patch 0/1] next updated version, fixed cleanup and some minors Christian Krafft
2007-01-25 3:34 ` [patch 1/1] " Christian Krafft
2007-01-25 5:19 ` Arnd Bergmann
2007-01-29 3:49 ` [Openipmi-developer] " Corey Minyard
2007-01-26 2:54 ` [patch 1/1] updated version, fixed the compiler warning Christoph Hellwig
2007-01-26 4:23 ` Arnd Bergmann [this message]
2007-01-28 23:07 ` Christian Krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701260523.04229.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=Christian@ozlabs$(echo .)org \
--cc=krafft@de$(echo .)ibm.com \
--cc=krafft@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=openipmi-developer@lists$(echo .)sourceforge.net \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox