From: Olof Johansson <olof@lixom•net>
To: Greg KH <gregkh@suse•de>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] [3/4] PMC-related cleanups
Date: Sun, 28 Jan 2007 21:02:38 -0600 [thread overview]
Message-ID: <20070129030238.GB6412@lixom.net> (raw)
In-Reply-To: <20070126223204.GE11008@suse.de>
On Fri, Jan 26, 2007 at 02:32:04PM -0800, Greg KH wrote:
> On Thu, Jan 25, 2007 at 02:20:02AM -0600, Olof Johansson wrote:
> > Introduce _SYSDEV_ATTR(), to be used to just define the struct, and not a
> > named variable with the attribute. Useful for arrays of sysdev_attributes.
> >
> > Signed-off-by: Olof Johansson <olof@lixom•net>
> >
> >
> > Index: powerpc/include/linux/sysdev.h
> > ===================================================================
> > --- powerpc.orig/include/linux/sysdev.h
> > +++ powerpc/include/linux/sysdev.h
> > @@ -98,12 +98,15 @@ struct sysdev_attribute {
> > };
> >
> >
> > -#define SYSDEV_ATTR(_name,_mode,_show,_store) \
> > -struct sysdev_attribute attr_##_name = { \
> > +#define _SYSDEV_ATTR(_name,_mode,_show,_store) \
> > +{ \
> > .attr = {.name = __stringify(_name), .mode = _mode }, \
> > .show = _show, \
> > .store = _store, \
> > -};
> > +}
>
> Oops, you need to add '.owner' to that attribute structure. In all
> fairness, it's a bug, not caused by anything that you did.
Got it, see repost.
> If you add that, feel free to add my:
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse•de>
>
> to the patch and send it through Paul.
Thanks!
-Olof
prev parent reply other threads:[~2007-01-29 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 8:20 [PATCH] [3/4] PMC-related cleanups Olof Johansson
2007-01-26 22:32 ` Greg KH
2007-01-29 3:02 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070129030238.GB6412@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=gregkh@suse$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox