From: Arnd Bergmann <arnd@arndb•de>
To: cbe-oss-dev@ozlabs•org, maynardj@us•ibm.com
Cc: linuxppc-dev@ozlabs•org, linux-kernel@vger•kernel.org,
oprofile-list@lists•sourceforge.net
Subject: Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
Date: Tue, 30 Jan 2007 05:07:46 +0100 [thread overview]
Message-ID: <200701300507.47068.arnd@arndb.de> (raw)
In-Reply-To: <45BE4F2A.5040702@us.ibm.com>
On Monday 29 January 2007 20:46, Maynard Johnson wrote:
> This is a clean up patch that includes the following changes:
>=20
> =A0 =A0 =A0 =A0 -It removes some macro definitions that are only used once
> =A0 =A0 =A0 =A0 =A0with the actual code.
> =A0 =A0 =A0 =A0 -Some comments were added to clarify the code based on fe=
edback
> =A0 =A0 =A0 =A0 =A0from the community.
> =A0 =A0 =A0 =A0 -The write_pm_cntrl() and set_count_mode() were passed a =
structure
> =A0 =A0 =A0 =A0 =A0element from a global variable. =A0The argument was re=
moved so the
> =A0 =A0 =A0 =A0 =A0functions now just operate on the global directly.
> =A0 =A0 =A0 =A0 -The set_pm_event() function call in the cell_virtual_cnt=
r() routine
> =A0 =A0 =A0 =A0 =A0was moved to a for-loop before the for_each_cpu loop
>=20
> Signed-off-by: Carl Love <carll@us•ibm.com>
> Signed-off-by: Maynard Johnson <mpjohn@us•ibm.com>
>=20
Acked-by: Arnd Bergmann <arnd.bergmann@de•ibm.com>
Just a small side note: Please give each of your patches a one-line
summary in the subject of the email. I'm filing this one under:
"cell: oprofile cleanup".
It would also be good if you could use a mailer that sends out
patches as inline, so you don't need to resort to using attachments.
Arnd <><
next prev parent reply other threads:[~2007-01-30 4:07 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-29 19:45 [RFC, PATCH 0/4] Add support to OProfile for profiling Cell BE SPUs -- update Maynard Johnson
2007-01-29 19:46 ` [RFC, PATCH 1/4] " Maynard Johnson
2007-01-30 4:07 ` Arnd Bergmann [this message]
2007-01-30 10:39 ` [Cbe-oss-dev] " Christoph Hellwig
2007-01-30 22:49 ` Carl Love
2007-01-30 22:57 ` Benjamin Herrenschmidt
2007-01-31 8:47 ` Christoph Hellwig
2007-01-30 22:59 ` Benjamin Herrenschmidt
2007-01-29 19:47 ` [RFC, PATCH 2/4] " Maynard Johnson
2007-01-30 4:08 ` [Cbe-oss-dev] " Arnd Bergmann
2007-01-30 23:51 ` Carl Love
2007-01-29 19:48 ` [RFC, PATCH 3/4] " Maynard Johnson
2007-01-30 4:24 ` [Cbe-oss-dev] " Arnd Bergmann
2007-01-30 15:31 ` Maynard Johnson
2007-01-31 0:35 ` Arnd Bergmann
2007-01-29 19:48 ` [RFC, PATCH 4/4] " Maynard Johnson
2007-01-30 7:39 ` [Cbe-oss-dev] " Arnd Bergmann
2007-01-30 7:53 ` Benjamin Herrenschmidt
2007-01-30 10:41 ` Christoph Hellwig
2007-01-30 23:09 ` Maynard Johnson
2007-01-30 21:41 ` Maynard Johnson
2007-01-30 22:54 ` Maynard Johnson
2007-01-30 23:34 ` Benjamin Herrenschmidt
2007-01-31 0:29 ` Maynard Johnson
2007-01-31 6:52 ` Arnd Bergmann
2007-02-02 16:47 ` Maynard Johnson
2007-02-03 7:40 ` Arnd Bergmann
2007-02-03 20:03 ` Maynard Johnson
2007-02-04 2:42 ` Arnd Bergmann
2007-02-04 17:11 ` Maynard Johnson
2007-01-30 23:31 ` Carl Love
2007-01-31 1:25 ` Christian Krafft
2007-01-31 6:06 ` Arnd Bergmann
2007-01-31 5:57 ` Arnd Bergmann
2007-02-02 19:27 ` Maynard Johnson
2007-02-03 23:49 ` Maynard Johnson
2007-02-04 2:52 ` Arnd Bergmann
2007-02-04 17:33 ` Maynard Johnson
2007-01-31 9:24 ` Milton Miller
2007-01-31 15:42 ` Arnd Bergmann
2007-02-01 18:56 ` Milton Miller
2007-02-02 0:54 ` Arnd Bergmann
2007-01-30 8:37 ` [RFC, PATCH 0/4] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701300507.47068.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=maynardj@us$(echo .)ibm.com \
--cc=oprofile-list@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox