Subject: Re: RFC: kprobes support for ppc32

From: Ananth N Mavinakayanahalli <[email-masked]>
Date: Tue, 30 Jan 2007 17:03:16 +0530

On Tue, Jan 30, 2007 at 11:46:30AM +0100, Christoph Hellwig wrote:
> On Tue, Jan 30, 2007 at 12:13:32AM -0600, Kumar Gala wrote:
> > +	depends on !BOOKE && KALLSYMS && EXPERIMENTAL && MODULES
> 
> Just curious: what's the problem with BOOKE?
> 
> > +#ifdef CONFIG_PPC64
> >   	regs->nip = (unsigned long)(((func_descr_t *)jp->entry)->entry);
> >   	regs->gpr[2] = (unsigned long)(((func_descr_t *)jp->entry)->toc);
> > +#else
> > +	regs->nip = (unsigned long)jp->entry;
> > +#endif
> 
> This should probably be split int a macro.
> 
> 
> 
> also I think you should not define kprobe_lookup_name for the 32bit
> case as the generic version should be fine for ppc32

Right. 32bit powerpc uses the SVR4 ABI and hence can just use the
generic version. In addition, since 32bit powerpc implementations don't
have a TD/TDI, they can be stubbed out too in the is_trap() check.

Ananth