From: Tom Rini <trini@kernel•crashing.org>
To: Olof Johansson <olof@lixom•net>
Cc: kimphill@freescale•com, paulus@samba•org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] generic RTC support for PPC
Date: Tue, 30 Jan 2007 11:53:36 -0700 [thread overview]
Message-ID: <20070130185336.GA10776@smtp.west.cox.net> (raw)
In-Reply-To: <20070130160340.GA25443@lixom.net>
On Tue, Jan 30, 2007 at 10:03:40AM -0600, Olof Johansson wrote:
> On Tue, Jan 30, 2007 at 12:37:12AM -0600, Kumar Gala wrote:
> >
> > On Jan 29, 2007, at 11:17 PM, Tom Rini wrote:
> >
> > >On Thu, Jan 25, 2007 at 01:37:54AM -0600, Olof Johansson wrote:
> > >
> > >>Make the PPC RTC functions use the generic RTC infrastructure if they
> > >>are not already defined (and an RTC is registered in the system).
> > >>
> > >>This should make it possible to remove the hideous direct access used
> > >>in some of the 83xx platforms.
> > >
> > >Now, I know I'm a bit late, and I've been quiet of late, but, um,
> > >why is
> > >there anything other than the RTC class stuff being used? I know
> > >drivers/char/genrtc.c isn't gone yet, but really, it should be in the
> > >process of being phased out. IMHO, it should depend on !POWERPC (or
> > >whatever the magic is to allow arch/ppc && !arch/powerpc).
> >
> > I think the problem was calling the RTC class code from the place's
> > we use rtc in ppc had locking issues or something like that.
Sounds like the RTC class code needs to be fixed up then. There's
really no good reason for drivers/char/genrtc.c to live anymore, a
better 'generic rtc' driver set exists now.
> Yes, and it does a direct call into the driver instead of using the
> subsystem, exporting the symbol from the driver. Not a very pretty
> solution but it's possible that the genrtc stuff wasn't available when
> it was first implemented.
genrtc is quite old, really :)
--
Tom Rini
next prev parent reply other threads:[~2007-01-30 18:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 7:37 [PATCH] generic RTC support for PPC Olof Johansson
2007-01-30 5:17 ` Tom Rini
2007-01-30 6:37 ` Kumar Gala
2007-01-30 16:03 ` Olof Johansson
2007-01-30 18:53 ` Tom Rini [this message]
2007-01-30 19:25 ` Kim Phillips
2007-01-30 19:55 ` David Brownell
2007-02-06 11:08 ` Paul Mackerras
2007-02-06 14:40 ` Kumar Gala
2007-02-06 15:24 ` Olof Johansson
2007-02-06 16:16 ` Kumar Gala
2007-02-07 1:55 ` Kim Phillips
2007-02-06 15:16 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130185336.GA10776@smtp.west.cox.net \
--to=trini@kernel$(echo .)crashing.org \
--cc=kimphill@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox