Subject: Re: [PATCH 1/4] PS3: Move system bus to platform directory

From: Christoph Hellwig <[email-masked]>
Date: Wed, 31 Jan 2007 09:49:46 +0100

On Tue, Jan 30, 2007 at 03:20:27PM -0800, Geoff Levand wrote:
> @@ -22,6 +22,9 @@
>  #define _PS3_PLATFORM_H
>  #include <linux/rtc.h>
> +#include <scsi/scsi.h>

> +enum ps3_dev_type {
> +	PS3_DEV_TYPE_STOR_DISK = TYPE_DISK,	/* 0 */
> +	PS3_DEV_TYPE_SB_GELIC = 3,
> +	PS3_DEV_TYPE_SB_USB = 4,
> +	PS3_DEV_TYPE_STOR_ROM = TYPE_ROM,	/* 5 */
> +	PS3_DEV_TYPE_SB_GPIO = 6,
> +	PS3_DEV_TYPE_STOR_FLASH = TYPE_RBC,	/* 14 */
> +};

I don't think you should take some of the values from the scsi device
types but reuse others.  Just do an enum of your own and if you ever
have to translate to scsi types somewhere use a lookup table.