Subject: Re: [PATCH 3/4] PS3: Fix DMA scatter-gather

From: Arnd Bergmann <[email-masked]>
Date: Tue, 6 Feb 2007 14:22:26 +0100

On Wednesday 31 January 2007 00:20, Geoff Levand wrote:
> @@ -272,10 +272,29 @@ static void ps3_unmap_single(struct devi
>  static int ps3_map_sg(struct device *_dev, struct scatterlist *sg, int nents,
>         enum dma_data_direction direction)
>  {
> +       struct ps3_system_bus_device *dev = to_ps3_system_bus_device(_dev);
> +       int i;
> +
>  #if defined(CONFIG_PS3_DYNAMIC_DMA)
>         BUG_ON("do");
> +       return -EPERM;
> +#else

Do you still need the #ifdef? Since there is no point executing this,
would guess you can just as well keep only the other version, right?

	Arnd <><