From: Arnd Bergmann <arnd@arndb•de>
To: cbe-oss-dev@ozlabs•org
Cc: Paul Mackerras <paulus@samba•org>, linuxppc-dev@ozlabs•org
Subject: Re: [Cbe-oss-dev] [PATCH 3/3] spufs: Fix bitrot of the SPU mmap facility
Date: Tue, 13 Feb 2007 13:16:34 +0100 [thread overview]
Message-ID: <200702131316.35365.arnd@arndb.de> (raw)
In-Reply-To: <20070213004618.82B78DDEE2@ozlabs.org>
On Tuesday 13 February 2007 01:46, Benjamin Herrenschmidt wrote:
> It looks like we've had some serious bitrot there mostly due to tracking
> of address_space's of mmap'ed files getting out of sync with the actual
> mmap code. The mfc, mss and psmap were not tracked properly and thus
> not invalidated on context switches (oops !)
>
> I also removed the various file->f_mapping = inode->i_mapping;
> assignments that were done in the other open() routines since that
> is already done for us by __dentry_open.
>
> One improvement we might want to do later is to assign the various
> ctx-> fields at mmap time instead of file open/close time so that we
> don't call unmap_mapping_range() on thing that have not been mmap'ed
>
> Finally, I added some smp_wmb's after assigning the ctx-> fields to make
> sure they are visible to other CPUs. I don't think this is really
> necessary as I suspect locking in the fs layer will make that happen
> anyway but better safe than sorry.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Acked-by: Arnd Bergmann <arnd.bergmann@de•ibm.com>
prev parent reply other threads:[~2007-02-13 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 0:46 [PATCH 0/3] spufs: mmap fixes and updates Benjamin Herrenschmidt
2007-02-13 0:46 ` [PATCH 1/3] spufs: remove need for struct page for SPEs Benjamin Herrenschmidt
2007-02-13 12:15 ` [Cbe-oss-dev] " Arnd Bergmann
2007-02-13 0:46 ` [PATCH 2/3] powerpc: Remove SPU struct page's for PS3 Benjamin Herrenschmidt
2007-02-13 12:16 ` [Cbe-oss-dev] " Arnd Bergmann
2007-02-13 0:46 ` [PATCH 3/3] spufs: Fix bitrot of the SPU mmap facility Benjamin Herrenschmidt
2007-02-13 12:16 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702131316.35365.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox