Subject: Re: [patch 1/4] ps3fb: thread updates

From: Christoph Hellwig <[email-masked]>
Date: Thu, 15 Feb 2007 18:50:07 +0100

On Thu, Feb 15, 2007 at 04:23:02PM +0100, [email-masked] wrote:
> +	do {
> +		try_to_freeze();
> +		error = down_interruptible(&ps3fb.sem);
> +		if (!error && !atomic_read(&ps3fb.ext_flip))
>  			ps3fb_sync(0);	/* single buffer */

this still can deadlock when calling kthread_stop.  You really want
to use wake_up_process to kick this thread or use a workqueue.