Subject: Re: [PATCH 4/6] [POWERPC] allow pSeries to build without CONFIG_PCI

From: Arnd Bergmann <[email-masked]>
Date: Sun, 4 Mar 2007 15:07:06 +0100

On Sunday 04 March 2007 07:04:44 Stephen Rothwell wrote:
>  config PCI
>         bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \ 
> -               || PPC_MPC52xx || (EMBEDDED && PPC_ISERIES) || MPC7448HPC2 || PPC_PS3 
> +               || PPC_MPC52xx || (EMBEDDED &&  (PPC_PSERIES || PPC_ISERIES)) \ 
> +               || MPC7448HPC2 || PPC_PS3 

This may be a dumb question, but system would you want to run a pSeries
kernel without PCI on? Is this just for build tests, or is there an
actual application for this?

>  procfs-$(CONFIG_PPC64)         := proc_ppc64.o
>  obj-$(CONFIG_PROC_FS)          += $(procfs-y)
> -rtaspci-$(CONFIG_PPC64)                := rtas_pci.o
> -obj-$(CONFIG_PPC_RTAS)         += rtas.o rtas-rtc.o $(rtaspci-y)
> +rtaspci-$(CONFIG_PPC64)-$(CONFIG_PCI)  := rtas_pci.o
> +obj-$(CONFIG_PPC_RTAS)         += rtas.o rtas-rtc.o $(rtaspci-y-y)
>  obj-$(CONFIG_RTAS_FLASH)       += rtas_flash.o
>  obj-$(CONFIG_RTAS_PROC)                += rtas-proc.o

The double -y suffix always confuses me. Do you mind turning this
into a Kconfig symbol instead?

config RTAS_PCI
	default y
	depends on PCI && PPC64 && PPC_RTAS

obj-$(CONFIG_RTAS_PCI)	+= rtas_pci.o

	Arnd <><