From: Ralf Baechle <ralf@linux-mips•org>
To: David Miller <davem@davemloft•net>
Cc: linux-arch@vger•kernel.org, sfr@canb•auug.org.au,
linuxppc-dev@ozlabs•org, paulus@samba•org, dwmw2@infradead•org,
rmk@arm•linux.org.uk
Subject: Re: [PATCH] [POWERPC] Wire up sys_sync_file_range
Date: Fri, 9 Mar 2007 11:59:02 +0000 [thread overview]
Message-ID: <20070309115901.GA29723@linux-mips.org> (raw)
In-Reply-To: <20070308.231341.41635421.davem@davemloft.net>
On Thu, Mar 08, 2007 at 11:13:41PM -0800, David Miller wrote:
> > On Fri, 2007-03-09 at 15:22 +1100, Stephen Rothwell wrote:
> > > This requires an architecture specific compat routine as u64s are passed
> > > in odd/even (high/low) register pairs on ppc32.
> > >
> > > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> >
> > Doesn't that apply to ARM and to 32-bit MIPS too? And perhaps others?
>
> Unfortunately in the MIPS case you'll have to do some ifdef'ing because
> the order of the "high" and "low" sub-part arguments is dependant upon
> endianness and MIPS can be both big and little endian.
I'd rather let the C compiler sort it out:
asmlinkage long compat_sys_sync_file_range(int fd, int dummy,
loff_t offset, loff_t nbytes, unsigned int flags)
{
sys_sync_file_range(fd, offset, nbytes, flags);
}
Which looks like it could be portable to PPC even, so maybe a little cpp
magic like:
#ifdef CONFIG_ABI_NEEDS_PADDING_
#define PAD_64BIT_ARG(x) unsigned int x,
#else
#define PAD_64BIT_ARG(x)
#endif
[...]
asmlinkage long sys_sync_file_range(int fd, PAD_64BIT_ARG(pad1)
loff_t offset, loff_t nbytes, unsigned int flags)
Ralf
next prev parent reply other threads:[~2007-03-09 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 4:22 [PATCH] [POWERPC] Wire up sys_sync_file_range Stephen Rothwell
2007-03-09 6:55 ` David Woodhouse
2007-03-09 7:13 ` David Miller
2007-03-09 11:59 ` Ralf Baechle [this message]
2007-03-15 10:23 ` Stephen Rothwell
2007-03-17 15:10 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309115901.GA29723@linux-mips.org \
--to=ralf@linux-mips$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dwmw2@infradead$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=rmk@arm$(echo .)linux.org.uk \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox