From: Randy Dunlap <randy.dunlap@oracle•com>
To: mohan@in•ibm.com
Cc: linuxppc-dev@ozlabs•org, fastboot@lists•osdl.org,
anton@samba•org, paulus@samba•org
Subject: Re: [Fastboot] [PATCH] Avoid hypervisor statistics calculation in real mode
Date: Tue, 20 Mar 2007 15:37:51 -0700 [thread overview]
Message-ID: <20070320153751.462da242.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070320133547.GA4191@in.ibm.com>
On Tue, 20 Mar 2007 19:05:47 +0530 Mohan Kumar M wrote:
> Cc: Anton Blanchard <anton@samba•org>
> Signed-off-by: Mohan Kumar M <mohan@in•ibm.com>
> ---
> arch/powerpc/platforms/pseries/hvCall.S | 34 ++++++++++++++++++++++++
> arch/powerpc/platforms/pseries/lpar.c | 2 -
> arch/powerpc/platforms/pseries/plpar_wrappers.h | 19 +++++++++++++
> include/asm-powerpc/hvcall.h | 15 ++++++++++
> 4 files changed, 69 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.21-rc4/arch/powerpc/platforms/pseries/hvCall.S
> ===================================================================
> --- linux-2.6.21-rc4.orig/arch/powerpc/platforms/pseries/hvCall.S
> +++ linux-2.6.21-rc4/arch/powerpc/platforms/pseries/hvCall.S
> @@ -123,6 +123,40 @@ _GLOBAL(plpar_hcall)
>
> blr /* return r3 = status */
>
> +
> +/* plpar_hcall_raw can be called in real mode. kexec/kdump need some
> + * hypervisor calls to be executed in real mode. So plpar_hcall_raw
> + * does not access the per cpu hypervisor call statistics variables,
> + * since these variables may not be present in the RMO region.
> + */
Hi,
Please use regular kernel long comment style (when not using
kernel-doc). E.g.:
/*
* foo
* bar
* this is a long comment (several lines)
*/
> +_GLOBAL(plpar_hcall_raw)
> + HMT_MEDIUM
> +
> + mfcr r0
> + stw r0,8(r1)
> +
> + std r4,STK_PARM(r4)(r1) /* Save ret buffer */
> +
> + mr r4,r5
> + mr r5,r6
> + mr r6,r7
> + mr r7,r8
> + mr r8,r9
> + mr r9,r10
> +
> + HVSC /* invoke the hypervisor */
> +
> + ld r12,STK_PARM(r4)(r1)
> + std r4, 0(r12)
> + std r5, 8(r12)
> + std r6, 16(r12)
> + std r7, 24(r12)
> +
> + lwz r0,8(r1)
> + mtcrf 0xff,r0
> +
> + blr /* return r3 = status */
> +
> _GLOBAL(plpar_hcall9)
> HMT_MEDIUM
>
> Index: linux-2.6.21-rc4/include/asm-powerpc/hvcall.h
> ===================================================================
> --- linux-2.6.21-rc4.orig/include/asm-powerpc/hvcall.h
> +++ linux-2.6.21-rc4/include/asm-powerpc/hvcall.h
> @@ -237,6 +237,21 @@ long plpar_hcall_norets(unsigned long op
> long plpar_hcall(unsigned long opcode, unsigned long *retbuf, ...);
>
> /**
> + * plpar_hcall_raw: - Make a pseries hypervisor call, but don't calculate
> + * hypervisor call statistics.
For kernel-doc, the first line must be:
* function - short description (one line only)
More detailed description can follow the parameters (like you have
done below).
> + * @opcode: The hypervisor call to make.
> + * @retbuf: Buffer to store up to 4 return arguments in.
> + *
> + * This call supports up to 6 arguments and 4 return arguments. Use
> + * PLPAR_HCALL_BUFSIZE to size the return argument buffer.
> + *
> + * Used when phyp interface needs to be called in real mode. Similar to
> + * plpar_hcall, but plpar_hcall_raw works in real mode and does not
> + * calculate hypervisor call statistics.
> + */
> +long plpar_hcall_raw(unsigned long opcode, unsigned long *retbuf, ...);
> +
> +/**
> * plpar_hcall9: - Make a pseries hypervisor call with up to 9 return arguments
> * @opcode: The hypervisor call to make.
> * @retbuf: Buffer to store up to 9 return arguments in.
Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-03-20 23:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 13:35 [PATCH] Avoid hypervisor statistics calculation in real mode Mohan Kumar M
2007-03-20 22:37 ` Randy Dunlap [this message]
2007-03-21 5:51 ` [Fastboot] " Mohan Kumar M
2007-03-21 15:30 ` Randy Dunlap
2007-03-23 6:18 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070320153751.462da242.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=anton@samba$(echo .)org \
--cc=fastboot@lists$(echo .)osdl.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mohan@in$(echo .)ibm.com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox