Subject: Re: [PATCH 3/11] ppc64: EEH: Tolerate high mmio

From: [email-masked] (Olof Johansson)
Date: Tue, 20 Mar 2007 20:25:34 -0500

On Mon, Mar 19, 2007 at 02:53:22PM -0500, Linas Vepstas wrote:
> 
> Some drivers will attempt to perform a lot of mmio even after
> an EEH event was detected. This is especially the case for fast cpu's
> and PCI-E slots. Be a bit more lenient in allowing this.
> 
> Signed-off-by: Linas Vepstas <[email-masked]>
> 
> ----
>  arch/powerpc/platforms/pseries/eeh.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.21-rc4-git4/arch/powerpc/platforms/pseries/eeh.c
> ===================================================================
> --- linux-2.6.21-rc4-git4.orig/arch/powerpc/platforms/pseries/eeh.c	2007-03-19 13:19:26.000000000 -0500
> +++ linux-2.6.21-rc4-git4/arch/powerpc/platforms/pseries/eeh.c	2007-03-19 13:19:30.000000000 -0500
> @@ -74,7 +74,7 @@
>   * is broken and panic.  This sets the threshold for how many read
>   * attempts we allow before panicking.
>   */
> -#define EEH_MAX_FAILS	100000
> +#define EEH_MAX_FAILS	2100000

100000 I can understand, it's a nice and round number. but why 2100000
of all possible values?

-Olof