From: olof@lixom•net (Olof Johansson)
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org, Stuart Yoder <stuart.yoder@freescale•com>
Subject: Re: [PATCH 10/17] bootwrapper: Add dt_set_mac_addresses().
Date: Wed, 21 Mar 2007 15:22:11 -0500 [thread overview]
Message-ID: <20070321202211.GA9682@lixom.net> (raw)
In-Reply-To: <46018F7B.40107@freescale.com>
On Wed, Mar 21, 2007 at 03:03:07PM -0500, Timur Tabi wrote:
> Segher Boessenkool wrote:
>
> >> If the property exists in the device tree, then it should be used, no?
> >> Whether or not it exists is not for the driver to decide.
> >
> > The property doesn't describe anything about the device;
> > it merely tells you something about what the firmware did
> > during booting.
>
> Ah, I see your point. But how else can the bootloader tell the kernel what MAC address to
> use? You need to make sure that both use the same address. I don't think the kernel
> command line supports MAC addresses.
>
> > Just everything everywhere that mentions "mac-address" should be
> > completely and utterly eradicated :-)
>
> Are you saying that Linux should not acknowledge the existence of the mac-address
> property, even though it's part of the OF spec?
Why? It's a property of the device -- the mac address it was assigned by
the vendor. It might not be a property of the ethernet controller chip,
but of the adapter it is.
> Depends on what you mean by a fix. Although I understand your point that the MAC address
> doesn't really belong in the device tree, I don't see any better place for it. So for
Right, there's no other place that makes sense. Leave it in there.
> now, I'm going on the assumption that mac-address and local-mac-address are valid
> properties, so it's just a question on *how* they should be supported. In that context,
> the kernel has been updated already, and some of U-Boot has also. Well, I'm ignoring some
> of the more obscure IBM systems, because I don't know anything about them. All that's
> left is 85xx, 86xx, and 5xxx, and then I can clean up the DTS files, and then as far as
> I'm concerned, I'm done.
We're using them in our driver/device tree as well.
-Olof
next prev parent reply other threads:[~2007-03-21 20:08 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 17:26 [PATCH 00/17] bootwrapper/cuImage patches Scott Wood
2007-03-16 17:27 ` [PATCH 01/17] bootwrapper: Make ft_create_node() pay attention to the parent parameter Scott Wood
2007-03-17 1:23 ` David Gibson
2007-03-16 17:27 ` [PATCH 02/17] bootwrapper: Add dt_ops methods Scott Wood
2007-03-17 1:24 ` David Gibson
2007-03-16 17:27 ` [PATCH 03/17] bootwrapper: Add xlate_reg(), and use it to find serial registers Scott Wood
2007-03-20 3:50 ` David Gibson
2007-03-20 16:34 ` Scott Wood
2007-03-21 3:12 ` David Gibson
2007-03-21 13:49 ` Segher Boessenkool
2007-03-21 16:01 ` Scott Wood
2007-03-21 19:11 ` Segher Boessenkool
2007-03-16 17:27 ` [PATCH 04/17] bootwrapper: Make compression of the kernel image optional Scott Wood
2007-03-17 1:25 ` David Gibson
2007-03-21 15:03 ` Patch: " Milton Miller
2007-03-16 17:28 ` [PATCH 05/17] bootwrapper: misc device tree fixes Scott Wood
2007-03-21 1:51 ` David Gibson
2007-03-22 16:22 ` Scott Wood
2007-03-23 3:26 ` David Gibson
2007-03-21 13:22 ` Segher Boessenkool
2007-03-16 17:28 ` [PATCH 06/17] Document the linux,network-index property Scott Wood
2007-03-17 1:26 ` David Gibson
2007-03-21 13:30 ` Segher Boessenkool
2007-03-21 14:48 ` Yoder Stuart-B08248
2007-03-21 18:57 ` Segher Boessenkool
2007-03-22 0:29 ` David Gibson
2007-03-22 11:11 ` Segher Boessenkool
2007-03-23 3:19 ` David Gibson
2007-03-23 11:36 ` Segher Boessenkool
2007-03-23 23:59 ` David Gibson
2007-03-24 0:23 ` Segher Boessenkool
2007-03-23 15:00 ` Scott Wood
2007-03-23 16:42 ` Segher Boessenkool
2007-03-16 17:28 ` [PATCH 07/17] bootwrapper: Add dt_set_memory(), to fill in the /memory node Scott Wood
2007-03-17 1:26 ` David Gibson
2007-03-21 13:32 ` Segher Boessenkool
2007-03-21 23:42 ` David Gibson
2007-03-22 11:02 ` Segher Boessenkool
2007-03-23 3:24 ` David Gibson
2007-03-23 6:49 ` Stefan Roese
2007-03-23 7:40 ` David Gibson
2007-03-23 12:34 ` Segher Boessenkool
2007-03-16 17:28 ` [PATCH 08/17] bootwrapper: Make setprop accept a const buffer Scott Wood
2007-03-17 1:27 ` David Gibson
2007-03-16 17:28 ` [PATCH 09/17] bootwrapper: Add dt_set_cpu_clocks() Scott Wood
2007-03-17 1:28 ` David Gibson
2007-03-16 17:28 ` [PATCH 10/17] bootwrapper: Add dt_set_mac_addresses() Scott Wood
2007-03-17 1:31 ` David Gibson
2007-03-18 0:22 ` Timur Tabi
2007-03-18 11:56 ` David Gibson
2007-03-19 15:09 ` Timur Tabi
2007-03-20 3:59 ` David Gibson
2007-03-20 14:00 ` Timur Tabi
2007-03-21 2:54 ` David Gibson
2007-03-21 15:01 ` Timur Tabi
2007-03-21 15:25 ` Jerry Van Baren
2007-03-21 15:55 ` Timur Tabi
2007-03-22 0:06 ` David Gibson
2007-03-22 15:13 ` Timur Tabi
2007-03-22 15:15 ` Jon Loeliger
2007-03-23 3:22 ` David Gibson
2007-03-23 14:38 ` Timur Tabi
2007-03-23 16:37 ` Segher Boessenkool
2007-03-23 16:42 ` Timur Tabi
2007-03-23 16:51 ` Segher Boessenkool
2007-03-23 16:54 ` Timur Tabi
2007-03-23 23:17 ` David Gibson
2007-03-20 18:17 ` Jon Loeliger
2007-03-21 13:45 ` Segher Boessenkool
2007-03-21 15:15 ` Timur Tabi
2007-03-21 19:07 ` Segher Boessenkool
2007-03-21 19:10 ` Timur Tabi
2007-03-21 19:34 ` Segher Boessenkool
2007-03-21 19:39 ` Timur Tabi
2007-03-21 19:48 ` Segher Boessenkool
2007-03-21 20:03 ` Timur Tabi
2007-03-21 20:22 ` Olof Johansson [this message]
2007-03-21 21:58 ` Segher Boessenkool
2007-03-21 21:54 ` Segher Boessenkool
2007-03-21 20:34 ` Doug Maxey
2007-03-21 22:01 ` Segher Boessenkool
2007-03-21 13:38 ` Segher Boessenkool
2007-03-21 15:09 ` Timur Tabi
2007-03-16 17:28 ` [PATCH 11/17] bootwrapper: Make set_cmdline non-static, and accept a const buffer Scott Wood
2007-03-17 1:36 ` David Gibson
2007-03-16 17:29 ` [PATCH 12/17] bootwrapper: Make set_cmdline() create /chosen if it doesn't exist Scott Wood
2007-03-21 13:32 ` Segher Boessenkool
2007-03-16 17:29 ` [PATCH 13/17] bootwrapper: Add ppcboot.h Scott Wood
2007-03-16 17:29 ` [PATCH 14/17] bootwrapper: Add support for cuboot platforms Scott Wood
2007-03-16 17:29 ` [PATCH 15/17] bootwrapper: Add cmd_wrap_dt Scott Wood
2007-03-16 17:29 ` [PATCH 16/17] bootwrapper: Add a cuImage target Scott Wood
2007-03-16 17:29 ` [PATCH 17/17] bootwrapper: cuboot for 83xx Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321202211.GA9682@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=stuart.yoder@freescale$(echo .)com \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox