From: olof@lixom•net (Olof Johansson)
To: Yoder Stuart-B08248 <stuart.yoder@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [Fwd: [PATCH Resend 01/02] Add Linux ASMP support for MPC8641D]
Date: Thu, 22 Mar 2007 10:51:55 -0500 [thread overview]
Message-ID: <20070322155155.GA19903@lixom.net> (raw)
In-Reply-To: <9696D7A991D0824DBA8DFAC74A9C5FA302B97F7C@az33exm25.fsl.freescale.net>
On Thu, Mar 22, 2007 at 08:32:33AM -0700, Yoder Stuart-B08248 wrote:
>
> > + mpic: pic@40000 {
> > + clock-frequency = <0>;
> > + interrupt-controller;
> > + #address-cells = <0>;
> > + #interrupt-cells = <2>;
> > + reg = <40000 40000>;
> > + built-in;
> > + compatible = "chrp,open-pic";
> > + device_type = "open-pic";
> > + big-endian;
> > + interrupts = <
> > + 18 2 49 2 19 2
> > + 2a 2 2b 2 4a 1
> > + 1d 2 1e 2 22 2
> > + 23 2 24 2 28 2
> > + >;
> > + };
> > + };
> > +};
>
> I think using the 'interrupts' property in this way is bad. It's
> being used to tell the pic which interrupts belong to it.
>
> The problem is that the interrupts property is being overloaded
> and used for a completely different purpose than that which
> it was originally intended and documented. Interrupt controllers
> should not have an interrupts property.
>
> The only reason I can see to do this is as a convenience to avoid
> walking the device tree. The pic code should walk the device tree
> to determine the irq numbers the running core.
Not speaking for the case of the freescale boards here, but not all
interrupts are in the device tree, nor do they have to. Especially for
PCI devices, etc.
This is quite a special case. Having a brand new property for it might
be a good idea. It's a pretty big hack anyway, so adding another one to
the device tree isn't that big a deal.
-Olof
next prev parent reply other threads:[~2007-03-22 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 14:25 [Fwd: [PATCH Resend 01/02] Add Linux ASMP support for MPC8641D] Jon Loeliger
2007-03-22 14:46 ` Kumar Gala
2007-03-22 15:32 ` Yoder Stuart-B08248
2007-03-22 15:40 ` Kumar Gala
2007-03-22 15:51 ` Olof Johansson [this message]
2007-03-22 15:44 ` Kumar Gala
2007-03-22 15:58 ` Yoder Stuart-B08248
2007-03-22 16:11 ` Kumar Gala
2007-03-22 21:01 ` Benjamin Herrenschmidt
2007-03-22 21:25 ` Kumar Gala
2007-03-22 23:02 ` Segher Boessenkool
2007-03-22 16:13 ` Segher Boessenkool
2007-03-23 3:55 ` Milton Miller
[not found] <mailman.532.1174628450.2645.linuxppc-dev@ozlabs.org>
2007-03-28 20:40 ` Siva Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322155155.GA19903@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=stuart.yoder@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox