Subject: Re: [PATCH 4/10] Add arch/powerpc driver for UIC, PPC4xx interrupt controller

From: David Gibson <[email-masked]>
Date: Fri, 23 Mar 2007 14:28:58 +1100

On Thu, Mar 22, 2007 at 10:51:18AM +0100, Domen Puncer wrote:
> On 22/03/07 20:22 +1100, David Gibson wrote:
> > +static int uic_set_irq_type(unsigned int virq, unsigned int flow_type)
> 
> > +	case IRQ_TYPE_LEVEL_HIGH:
> > +		trigger = 0; polarity = 1;
> > +		break;
> > +	case IRQ_TYPE_LEVEL_LOW:
> > +		trigger = 0; polarity = 1;
> 
> Is this intended to be the same?

Oops, no.  Thanks for spotting that, the Ebony has no level-low
devices, so I didn't notice any problems.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson