From: Olaf Hering <olaf@aepfle•de>
To: Sylvain Munaut <tnt@246tNt•com>
Cc: linuxppc-dev@ozlabs•org, Paul Mackeras <paulus@samba•org>
Subject: Re: [PATCH] add modalias file for of_devices to sysfs
Date: Tue, 3 Apr 2007 14:28:59 +0200 [thread overview]
Message-ID: <20070403122859.GA19547@aepfle.de> (raw)
In-Reply-To: <461137B8.9000404@246tNt.com>
On Mon, Apr 02, Sylvain Munaut wrote:
> In my patch to "unify" the uevent generation, I've made a separate
> function that generate
> the modalias string especially so that we don't repeat the same piece of
> code twice.
>
> It's prototype is :
>
> +static ssize_t of_device_get_modalias(struct of_device *ofdev,
> + char *str, ssize_t len)
>
> So the modalias_show can be shortened to
>
> return of_device_get_modalias(to_of_device(dev), buf, PAGE_SIZE);
macio_sysfs needs to be adapted as well.
Your version does not append a newline to the moalias content.
prev parent reply other threads:[~2007-04-03 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-02 12:45 [PATCH] add modalias file for of_devices to sysfs Olaf Hering
2007-04-02 17:04 ` Sylvain Munaut
2007-04-03 12:28 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070403122859.GA19547@aepfle.de \
--to=olaf@aepfle$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=tnt@246tNt$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox