From: olof@lixom•net (Olof Johansson)
To: Kim Phillips <kim.phillips@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/4] powerpc: document max-speed and interface-type properties
Date: Wed, 11 Apr 2007 13:32:25 -0500 [thread overview]
Message-ID: <20070411183225.GA30055@lixom.net> (raw)
In-Reply-To: <20070411130913.68501459.kim.phillips@freescale.com>
On Wed, Apr 11, 2007 at 01:09:13PM -0500, Kim Phillips wrote:
> On Tue, 10 Apr 2007 20:49:58 -0500
> olof@lixom•net (Olof Johansson) wrote:
>
> > On Tue, Apr 10, 2007 at 06:19:49PM -0500, Kim Phillips wrote:
> > > On Tue, 10 Apr 2007 17:48:09 -0500
> > > olof@lixom•net (Olof Johansson) wrote:
> > >
> > > >
> > > > Do you really need to set max speed for devices that are at the default
> > > > max speed for the interface type? Seems redundant.
> > > >
> > > > If for example there's an rgmii interface that for some reason only can
> > > > handle 100Mbit, that'd be different.
> > >
> > > rgmii@100/10Mbit are supported interface/speed combinations for our MDS boards; see pdf p. 72 in:
> > >
> > > http://www.freescale.com/files/32bit/doc/user_guide/MPC8360EAMDSUM.pdf
> >
> > Right, my bad. Sorry for the confusion -- That comment was meant for the
> > next patch in the series where you specify the speed even for interfaces
> > that support the full max.
> >
> just to be clear, you want the logic in ucc_geth (phylib
> patch) to be enhanced such that it sets the maximum max-speed
> based on the interface-type, e.g. if rgmii specified and
> max-speed not specified, assign max-speed = 1000?
Yes, that would seem logical, wouldn't it?
-Olof
next prev parent reply other threads:[~2007-04-11 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 21:56 [PATCH 1/4] powerpc: document max-speed and interface-type properties Kim Phillips
2007-04-10 22:48 ` Olof Johansson
2007-04-10 23:19 ` Kim Phillips
2007-04-11 1:49 ` Olof Johansson
2007-04-11 18:09 ` Kim Phillips
2007-04-11 18:32 ` Olof Johansson [this message]
2007-04-11 21:45 ` Joakim Tjernlund
2007-04-11 22:56 ` Kim Phillips
2007-04-12 6:49 ` Joakim Tjernlund
2007-04-12 7:06 ` Segher Boessenkool
2007-04-16 17:28 ` Andy Fleming
2007-04-16 18:19 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070411183225.GA30055@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=kim.phillips@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox