Subject: Re: [PATCH 10/13] powerpc: Add arch/powerpc mv64x60 PCI setup

From: Arnd Bergmann <[email-masked]>
Date: Thu, 26 Apr 2007 02:25:27 +0200

On Thursday 26 April 2007, Mark A. Greer wrote:
> +void __init mv64x60_pci_init(void)
> +{
> +       struct device_node *np = NULL;
> +
> +       ppc_md.pci_exclude_device = mv64x60_exclude_device;
> +
> +       while ((np = of_find_compatible_node(np, "pci", "mv64x60-pci")))
> +               mv64x60_add_bridge(np);
> +}

This is a similar mistake to the previous two, but somewhat different:

You actually duplicate code that is already present in of_platform.c.
AFAICS, all you should need to do is implement the ppc_md.pci_setup_phb()
function instead of your own handmade device tree scanning.

	Arnd <><