Subject: Re: [PATCH 8/13] powerpc: Add arch/powerpc mv64x60_eth platform data setup

From: "Dale Farnsworth" <[email-masked]>
Date: Wed, 25 Apr 2007 23:00:26 -0700

On Thu, Apr 26, 2007 at 12:18:45AM +0000, Arnd Bergmann wrote:
> On Thursday 26 April 2007, Mark A. Greer wrote:
> > Index: linux-2.6-powerpc-df/arch/powerpc/sysdev/mv64x60.c
> > --- linux-2.6-powerpc-df.orig/arch/powerpc/sysdev/mv64x60.c
> > +++ linux-2.6-powerpc-df/arch/powerpc/sysdev/mv64x60.c
> > @@ -511,3 +511,138 @@ ret_node_put:
> > }
> >
> >arch_initcall(mv64x60_mpsc_platform_device_init);
> > +
> > +/*
> > + * Create mv64x60_eth platform device
> > + */
> > +static int __init eth_register_shared_pdev(struct device_node *np)
> > +{
> > +	struct platform_device *pdev;
> 
> No need to put this into architecture specific code, just register
> the of_platform_driver from mv643xx_init_module and use the device
> you get passed in there.
> 
> Once arch/ppc is dead, you can remove the platform_driver from mv643xx
> entirely.

Like with the mpsc driver, there is an existing platform-driver-based
ethernet driver used by MIPS and powerpc platforms.  OF isn't universal yet.

-Dale