Subject: Re: [PATCH] [2.6.22] pasemi: hardware rng driver

From: Michael Buesch <[email-masked]>
Date: Thu, 26 Apr 2007 11:23:57 +0200

On Thursday 26 April 2007 01:38:31 Arnd Bergmann wrote:
> On Wednesday 25 April 2007, Olof Johansson wrote:
> 
> > +static void __iomem *rng_regs;
> > +
> > +static int pasemi_rng_data_present(struct hwrng *rng)
> > +{
> > +	return (in_le32(rng_regs + SDCRNG_CTL_REG)
> > +		& SDCRNG_CTL_FVLD_M) ? 1 : 0;
> > +}
> 
> It would be nicer to get rid of the global rng_regs variable by sticking
> it into rng->priv.

Yeah, I think that would be better. Saves one global variable.

-- 
Greetings Michael.