Subject: Re: [PATCH] Xilinx framebuffer device driver - 2nd version

From: Arnd Bergmann <[email-masked]>
Date: Thu, 26 Apr 2007 22:35:21 +0200

> @@ -118,6 +118,12 @@ struct xilinxfb_drvdata {
>   #define to_xilinxfb_drvdata(_info) \
>   	container_of(_info, struct xilinxfb_drvdata, info)
> 
> +#define xilinx_fb_out_be32(driverdata, offset, val) \
> +	if (driverdata->use_dcr) \
> +		mtdcr(driverdata->regs_phys + offset, val); \
> +	else \
> +		out_be32(driverdata->regs + offset, val)
> +
>   static int
>   xilinx_fb_setcolreg(unsigned regno, unsigned red, unsigned green, unsigned blue,
>   	unsigned transp, struct fb_info *fbi)

This should probably be an inline function, or use do { ... } while (0) 
instead, to make it less error-prone, see
http://kernelnewbies.org/FAQ/DoWhile0 for an explanation.

	Arnd <><