From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: Olof Johansson <olof@lixom•net>, paulus@samba•org
Subject: Re: [PATCH v2] powerpc: Show current speed in /proc/cpuinfo
Date: Wed, 2 May 2007 01:48:07 +0200 [thread overview]
Message-ID: <200705020148.07954.arnd@arndb.de> (raw)
In-Reply-To: <20070430035339.GA15771@lixom.net>
On Monday 30 April 2007, Olof Johansson wrote:
> On other architectures, the frequency in /proc/cpuinfo moves with cpufreq
> changes. It makes sense to do the same on powerpc to keep users from
> getting confused.
>=20
> Change the format to three decimals, having full Hz granularity is silly
> these days. Also specify in output if it's cpufreq or firmware-reported:
>=20
> clock =A0 =A0 =A0 =A0 =A0 : 1250.000MHz (from firmware)
> or:
> clock =A0 =A0 =A0 =A0 =A0 : 2500.000MHz (actual speed)
Good idea, but I'd be _very_ careful with changing any field in
/proc/cpuinfo. Having the extra text in there can easily confuse
parsers in poorly written user applications, maybe even in good ones ;-)
How about rather adding a new line in there for one of the fields, either
clock : 1250.000MHz
max-clock : 2500.000MHz
or
clock : 2500.000MHz
current-clock : 1250.000MHz
Arnd <><
next prev parent reply other threads:[~2007-05-01 23:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 8:41 [PATCH] powerpc: Show current speed in /proc/cpuinfo Olof Johansson
2007-04-27 9:00 ` Matt Sealey
2007-04-27 9:25 ` Benjamin Herrenschmidt
2007-04-27 18:14 ` Olof Johansson
2007-04-27 9:24 ` Benjamin Herrenschmidt
2007-04-27 17:51 ` Olof Johansson
2007-04-30 3:53 ` [PATCH v2] " Olof Johansson
2007-05-01 23:48 ` Arnd Bergmann [this message]
2007-05-04 3:15 ` Olof Johansson
2007-05-04 3:16 ` [PATCH v3] " Olof Johansson
2007-05-04 3:39 ` Stephen Rothwell
2007-05-04 3:46 ` Olof Johansson
2007-05-04 4:00 ` Paul Mackerras
2007-05-04 4:39 ` [PATCH] pasemi: update ppc_proc_freq from cpufreq driver Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705020148.07954.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox