From: Arnd Bergmann <arnd@arndb•de>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/4] Add support for 750CL Holly board
Date: Sat, 5 May 2007 13:08:11 +0200 [thread overview]
Message-ID: <200705051308.11457.arnd@arndb.de> (raw)
In-Reply-To: <1178308913.3026.238.camel@zod.rchland.ibm.com>
On Friday 04 May 2007, Josh Boyer wrote:
>=20
> > If it's an IBM product, it should come with a product code like 123-456=
7,
> > which fits in here, instead of just listing the CPU.
>=20
> Erm... why? =A0There are other boards that don't do this as well...
We did it on the Cell blade because we were asked to do it by
the people responsible for the hardware, who were following
their rules. I assumed that the same rules apply here as well,
but maybe they are specific to the server line.
> > > --- linux-2.6.orig/drivers/net/tsi108_eth.h
> > > +++ linux-2.6/drivers/net/tsi108_eth.h
> > > @@ -49,7 +49,11 @@
> > > =A0 */
> > > =A0#define PHY_MV88E=A0=A01=A0=A0=A0=A0=A0=A0=A0/* Marvel 88Exxxx PHY=
*/
> > > =A0#define PHY_BCM54XX=A0=A0=A0=A0=A0=A0=A0=A02=A0=A0=A0=A0=A0=A0=A0/=
* Broardcom BCM54xx PHY */
> > > +#if defined(CONFIG_HOLLY)
> > > +#define TSI108_PHY_TYPE PHY_BCM54XX
> > > +#else
> > > =A0#define TSI108_PHY_TYPE=A0=A0=A0=A0PHY_MV88E
> > > +#endif
> > > =A0
> >=20
> > this breaks multiplatform setups.
>=20
> I know. =A0Looking for a better suggestions. =A0Kumar suggested a Kconfig
> option at least, which is what I'm going to go with unless someone has a
> better idea...
A Kconfig option won't help at all. The phy should come as a device node
below the ethernet device. When probing the device, look at the
"compatible" and "reg" properties in there.
Arnd <><
next prev parent reply other threads:[~2007-05-05 11:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 18:13 [PATCH 0/4] Add support for 750CL Holly board Josh Boyer
2007-05-04 18:14 ` [PATCH 1/4] " Josh Boyer
2007-05-04 18:35 ` Kumar Gala
2007-05-04 19:11 ` Josh Boyer
2007-05-04 19:01 ` Olof Johansson
2007-05-04 19:18 ` Josh Boyer
2007-05-08 23:17 ` Benjamin Herrenschmidt
2007-05-04 19:44 ` Arnd Bergmann
2007-05-04 20:01 ` Josh Boyer
2007-05-05 11:08 ` Arnd Bergmann [this message]
2007-05-05 11:44 ` Josh Boyer
2007-05-05 14:41 ` Olof Johansson
2007-05-08 23:24 ` Benjamin Herrenschmidt
2007-05-08 23:20 ` Benjamin Herrenschmidt
2007-05-09 0:32 ` Josh Boyer
2007-05-05 14:39 ` Olof Johansson
2007-05-05 15:11 ` Josh Boyer
2007-05-06 0:09 ` Arnd Bergmann
2007-05-08 23:19 ` Benjamin Herrenschmidt
2007-05-09 0:39 ` Josh Boyer
2007-05-04 18:15 ` [PATCH 2/4] Holly defconfig Josh Boyer
2007-05-04 18:16 ` [PATCH 3/4] Holly DTS Josh Boyer
2007-05-04 23:51 ` David Gibson
2007-05-05 3:18 ` Josh Boyer
2007-05-04 18:16 ` [PATCH 4/4] Holly bootwrapper Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705051308.11457.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox