From: olof@lixom•net (Olof Johansson)
To: Arnd Bergmann <arnd@arndb•de>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/4] Add support for 750CL Holly board
Date: Sat, 5 May 2007 09:39:25 -0500 [thread overview]
Message-ID: <20070505143925.GA21503@lixom.net> (raw)
In-Reply-To: <200705042144.31194.arnd@arndb.de>
On Fri, May 04, 2007 at 09:44:30PM +0200, Arnd Bergmann wrote:
> > --- linux-2.6.orig/include/asm-powerpc/tsi108.h
> > +++ linux-2.6/include/asm-powerpc/tsi108.h
> > @@ -68,7 +68,11 @@
> > #define TSI108_PB_ERRCS_ES (1 << 1)
> > #define TSI108_PB_ISR_PBS_RD_ERR (1 << 8)
> >
> > +#ifdef CONFIG_HOLLY
> > +#define TSI108_PCI_CFG_BASE_PHYS (0x7c000000)
> > +#else
> > #define TSI108_PCI_CFG_BASE_PHYS (0xfb000000)
> > +#endif
> > #define TSI108_PCI_CFG_SIZE (0x01000000)
> > /* Global variables */
> >
>
> Same here.
It would be very easy to take tsi108_setup_pci take the config base as
a function paramter and pass it in from the board setup code, and store
it in a static variable to be used for the tsi108_clear_pci_cfg_error
function.
That'd easily make the code multiplatform friendly without having to
add it to the device tree. Very few other platforms have the config base
address in there, if any. It shouldn't be a requirement that Holly has it.
-Olof
next prev parent reply other threads:[~2007-05-05 14:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 18:13 [PATCH 0/4] Add support for 750CL Holly board Josh Boyer
2007-05-04 18:14 ` [PATCH 1/4] " Josh Boyer
2007-05-04 18:35 ` Kumar Gala
2007-05-04 19:11 ` Josh Boyer
2007-05-04 19:01 ` Olof Johansson
2007-05-04 19:18 ` Josh Boyer
2007-05-08 23:17 ` Benjamin Herrenschmidt
2007-05-04 19:44 ` Arnd Bergmann
2007-05-04 20:01 ` Josh Boyer
2007-05-05 11:08 ` Arnd Bergmann
2007-05-05 11:44 ` Josh Boyer
2007-05-05 14:41 ` Olof Johansson
2007-05-08 23:24 ` Benjamin Herrenschmidt
2007-05-08 23:20 ` Benjamin Herrenschmidt
2007-05-09 0:32 ` Josh Boyer
2007-05-05 14:39 ` Olof Johansson [this message]
2007-05-05 15:11 ` Josh Boyer
2007-05-06 0:09 ` Arnd Bergmann
2007-05-08 23:19 ` Benjamin Herrenschmidt
2007-05-09 0:39 ` Josh Boyer
2007-05-04 18:15 ` [PATCH 2/4] Holly defconfig Josh Boyer
2007-05-04 18:16 ` [PATCH 3/4] Holly DTS Josh Boyer
2007-05-04 23:51 ` David Gibson
2007-05-05 3:18 ` Josh Boyer
2007-05-04 18:16 ` [PATCH 4/4] Holly bootwrapper Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070505143925.GA21503@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox