From: Arnd Bergmann <arnd@arndb•de>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>
Cc: Olof Johansson <olof@lixom•net>, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/4] Add support for 750CL Holly board
Date: Sun, 6 May 2007 02:09:21 +0200 [thread overview]
Message-ID: <200705060209.21852.arnd@arndb.de> (raw)
In-Reply-To: <1178377874.3393.17.camel@zod.rchland.ibm.com>
On Saturday 05 May 2007, Josh Boyer wrote:
> >
> > It would be very easy to take tsi108_setup_pci take the config base as
> > a function paramter and pass it in from the board setup code, and store
> > it in a static variable to be used for the tsi108_clear_pci_cfg_error
> > function.
> >
> > That'd easily make the code multiplatform friendly without having to
> > add it to the device tree. Very few other platforms have the config base
> > address in there, if any. It shouldn't be a requirement that Holly has it.
>
> Yeah, after thinking about it, that's what I plan on doing actually.
>
Yes, sounds fair enough. The more interesting bits to clean up in the
driver are to convert it to an of_platform_driver and to use phylib, and
then autodetecting this will be trivial, and until then hardcoding in the
board setup seems a good solution.
Arnd <><
next prev parent reply other threads:[~2007-05-06 0:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 18:13 [PATCH 0/4] Add support for 750CL Holly board Josh Boyer
2007-05-04 18:14 ` [PATCH 1/4] " Josh Boyer
2007-05-04 18:35 ` Kumar Gala
2007-05-04 19:11 ` Josh Boyer
2007-05-04 19:01 ` Olof Johansson
2007-05-04 19:18 ` Josh Boyer
2007-05-08 23:17 ` Benjamin Herrenschmidt
2007-05-04 19:44 ` Arnd Bergmann
2007-05-04 20:01 ` Josh Boyer
2007-05-05 11:08 ` Arnd Bergmann
2007-05-05 11:44 ` Josh Boyer
2007-05-05 14:41 ` Olof Johansson
2007-05-08 23:24 ` Benjamin Herrenschmidt
2007-05-08 23:20 ` Benjamin Herrenschmidt
2007-05-09 0:32 ` Josh Boyer
2007-05-05 14:39 ` Olof Johansson
2007-05-05 15:11 ` Josh Boyer
2007-05-06 0:09 ` Arnd Bergmann [this message]
2007-05-08 23:19 ` Benjamin Herrenschmidt
2007-05-09 0:39 ` Josh Boyer
2007-05-04 18:15 ` [PATCH 2/4] Holly defconfig Josh Boyer
2007-05-04 18:16 ` [PATCH 3/4] Holly DTS Josh Boyer
2007-05-04 23:51 ` David Gibson
2007-05-05 3:18 ` Josh Boyer
2007-05-04 18:16 ` [PATCH 4/4] Holly bootwrapper Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705060209.21852.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox