Subject: Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support

From: Vitaly Bordug <[email-masked]>
Date: Sun, 6 May 2007 11:44:29 +0400

On Sun, 6 May 2007 03:04:14 +0200
Segher Boessenkool wrote:

> > +		pcmcia@0080 {
> 
> > +			#interrupt-cells = <1>;
> 
> > +			interrupt-parent = <ff000000>;
> > +			interrupts = <d 1>;
> > +		};
> 
> Since this node's children's interrupt representation
> is different from the node's parent's, you need an
> interrupt-map in here.  You also forgot "#address-cells"
> and I think you need "ranges" too?
> 
Well, in fact it does not introduce SoC device different from any others
represented inside soc885 node. mk_int_int_mask() is just special
way of enabling irq for PCMCIA stuff, in addition to normal pic stuff.

Emm. Why would I need #address-cells and ranges here? it uses parent bus address space...

-- 
Sincerely, Vitaly