From: olof@lixom•net (Olof Johansson)
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH 4/6] Device tree aware EMAC driver
Date: Sun, 6 May 2007 22:56:39 -0500 [thread overview]
Message-ID: <20070507035639.GA5567@lixom.net> (raw)
In-Reply-To: <20070507014051.GF16165@localhost.localdomain>
Hi,
On Mon, May 07, 2007 at 11:40:51AM +1000, David Gibson wrote:
> On Sun, May 06, 2007 at 07:57:23PM -0500, Olof Johansson wrote:
> > On Mon, May 07, 2007 at 10:30:19AM +1000, David Gibson wrote:
> > > This is BenH's rewritten, device tree aware driver for the IBM/AMCC
> > > EMAC, ethernet MAC controller ASIC found on various 4xx CPUs and also
> > > the Axon bridge. Tweaked to build on current kernels.
> >
> > Shouldn't benh have a signoff line on it as well in that case?
>
> Well, his patch which I tweaked didn't have his signoff, so I didn't
> think I ought to add it.
Heh, ok.
> > Is it ibm_emac or ibm_newemac? All file headers say ibm_emac, and there's
> > still Kconfig references to ibm_emac.
>
> It's ibm_newemac, the file headers just haven't been updated. The
> Kconfig changes referring to ibm_emac are just because the patch moves
> the suboptions for the old emac driver into their own subdirectory,
> and it inhibits selecting the old emac driver in arch/powerpc.
Hm, so it both modifies the old driver and adds the new one? Is the plan
to have both of them in parallel? Sounds wasteful, but I guess it'll be
hard to avoid until 4xx is dead in arch/ppc.
> > (Is this just posted FYI? If not, it should really go to netdev/jgarzik
> > instead, right?)
>
> This is just FYI at the moment, or rather, it's not really an Ebony
> related patch but it's in this series because the Ebony support is
> much more interesting if the ethernet works.
Ok. It really sucks trying to review patches of this size, but I'll try
to make a few passes over it.
It'd be useful to just see the incremental steps of how it was morphed
from the current driver, but that's a pain to recreate once you have
this kind of blob. Especially if you inherited the bulk of it. :-)
-Olof
next prev parent reply other threads:[~2007-05-07 3:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 5:54 [0/6] Ebony support David Gibson
2007-05-04 5:57 ` [PATCH 5/6] Support for the Ebony 440GP reference board in arch/powerpc David Gibson
2007-05-04 14:36 ` Olof Johansson
2007-05-05 18:43 ` Milton Miller
2007-05-05 19:02 ` Olof Johansson
2007-05-05 20:37 ` Segher Boessenkool
2007-05-06 0:43 ` David Gibson
2007-05-06 1:58 ` Segher Boessenkool
2007-05-07 3:22 ` David Gibson
2007-05-07 3:45 ` Olof Johansson
2007-05-07 4:02 ` David Gibson
2007-05-07 10:41 ` Josh Boyer
2007-05-04 5:57 ` [PATCH 1/6] Only legacy ports should allow addr/irq changes via setserial David Gibson
2007-05-04 5:57 ` [PATCH 2/6] Use resource_size_t for serial port IO addresses David Gibson
2007-05-04 5:57 ` [PATCH 3/6] Add device tree for Ebony David Gibson
2007-05-04 5:57 ` [PATCH 6/6] Early serial debug support for PPC44x David Gibson
2007-05-07 0:30 ` [PATCH 4/6] Device tree aware EMAC driver David Gibson
2007-05-07 0:57 ` Olof Johansson
2007-05-07 1:40 ` David Gibson
2007-05-07 3:56 ` Olof Johansson [this message]
2007-05-07 4:10 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070507035639.GA5567@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox