From: David Gibson <david@gibson•dropbear.id.au>
To: Loeliger Jon-LOELIGER <jdl@freescale•com>,
Kumar Gala <galak@kernel•crashing.org>,
jdl@jdl•com, linuxppc-dev@ozlabs•org, paulus@samba•org,
Olof Johansson <olof@lixom•net>,
arnd@ardnb•de, Tabi Timur-B04825 <timur@freescale•com>
Subject: Re: Current powerpc.git build failures
Date: Wed, 9 May 2007 11:57:54 +1000 [thread overview]
Message-ID: <20070509015753.GH4198@localhost.localdomain> (raw)
In-Reply-To: <20070509015146.GF4198@localhost.localdomain>
On Wed, May 09, 2007 at 11:51:46AM +1000, David Gibson wrote:
> On Tue, May 08, 2007 at 06:18:29PM -0700, Jon Loeliger wrote:
> > > Looks like. AFAICT, the generic nopud.h and nopmd.h headers expect
> > > page.h to be included before pgtable.h. I think this patch should fix
> > > the problem, but I don't have a suitable board to test with.
> > >
> >
> > That would be me. I'll give it a spin.
>
> Duh, of course, I wasn't thinking at that point and realizing I could
> at least test the build was fixed. Which I've now done; and found
> some other warnings caused by my patch. Improved fix below. Unless
> you report that it breaks something, I'll ask Paul to pull it.
Gah, sorry. Really below, this time:
Fix missing printk() parameter in physmap_of.c MTD driver
Squashes a compiler warning, and provides more useful information in
the case messed up device tree information.
Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Index: working-2.6/drivers/mtd/maps/physmap_of.c
===================================================================
--- working-2.6.orig/drivers/mtd/maps/physmap_of.c 2007-05-07 12:57:07.000000000 +1000
+++ working-2.6/drivers/mtd/maps/physmap_of.c 2007-05-09 11:53:53.000000000 +1000
@@ -186,7 +186,7 @@ static int __devinit of_physmap_probe(st
else {
if (strcmp(of_probe, "ROM"))
dev_dbg(&dev->dev, "map_probe: don't know probe type "
- "'%s', mapping as rom\n");
+ "'%s', mapping as rom\n", of_probe);
info->mtd = do_map_probe("mtd_rom", &info->map);
}
if (info->mtd == NULL) {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-05-09 1:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 19:17 Current powerpc.git build failures Olof Johansson
2007-05-08 20:30 ` Timur Tabi
2007-05-08 20:38 ` Kumar Gala
2007-05-09 1:09 ` David Gibson
2007-05-09 1:18 ` Loeliger Jon-LOELIGER
2007-05-09 1:51 ` David Gibson
2007-05-09 1:57 ` David Gibson [this message]
2007-05-09 5:20 ` David Gibson
2007-05-08 22:47 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509015753.GH4198@localhost.localdomain \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=arnd@ardnb$(echo .)de \
--cc=galak@kernel$(echo .)crashing.org \
--cc=jdl@freescale$(echo .)com \
--cc=jdl@jdl$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
--cc=paulus@samba$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox