Subject: Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

From: Andrew Morton <[email-masked]>
Date: Mon, 14 May 2007 14:21:25 -0700

On Wed, 09 May 2007 02:31:25 +0400
Vitaly Bordug <[email-masked]> wrote:

> +/* 
> + * Some internal interrupt registers use an 8-bit mask for the interrupt
> + * level instead of a number.
> + */
> +static inline uint mk_int_int_mask(uint mask) {
> +	return (1 << (7 - (mask/2)));
> +}

grumble.  "uint" isn't a favoured "type".  Please prefer to
use "unsigned int" if that's what is meant.  Or maybe u32,
if that's more appropriate - and it probably is, as we're
dealing with device registers here.