public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: olof@lixom•net (Olof Johansson)
To: Christoph Hellwig <hch@lst•de>
Cc: linuxppc-dev@ozlabs•org, linux-pcmcia@lists•infradead.org,
	paulus@samba•org, linux-kernel@vger•kernel.org,
	Dominik Brodowski <linux@brodo•de>
Subject: Re: [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t
Date: Mon, 14 May 2007 17:57:31 -0500	[thread overview]
Message-ID: <20070514225731.GA4191@lixom.net> (raw)
In-Reply-To: <20070513214608.GA26187@lst.de>

On Sun, May 13, 2007 at 11:46:08PM +0200, Christoph Hellwig wrote:
> On Sat, May 12, 2007 at 09:31:05AM -0500, Olof Johansson wrote:
> > ppc64 really needs ioaddr_t to be 64-bit, since I/O addresses really
> > are MMIO addresses, and remapped to a high range.
> > 
> > While the type is exported to userspace, there hasn't been any platforms
> > with PCMCIA on 64-bit powerpc until now, so changing it won't regress
> > any existing users.
> 
> In fact the only use of the type should be in the obsolete ioctl-based user
> interface.  So instead of changing the size of the type you should
> 
>  a) make sure you're not using cardmgr
>  b) fix up those places that still use ioaddr_t where they shouldn't
>     and switch the to kio_addr_t (why not just unsigned long like all
>     other busses?) 

I just noticed that feature-removal-schedule.txt says November 2005 for
the removal of the pcmcia ioctl's, but they're still there. I'm missing
the history here, any reason they weren't removed yet?


-Olof

  reply	other threads:[~2007-05-14 22:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-12 14:31 [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t Olof Johansson
2007-05-13 21:22 ` Olof Johansson
2007-05-13 21:46 ` Christoph Hellwig
2007-05-14 22:57   ` Olof Johansson [this message]
2007-05-15  5:52     ` Christoph Hellwig
2007-05-14 22:08 ` Andrew Morton
2007-05-14 22:47   ` Benjamin Herrenschmidt
2007-05-14 22:59     ` Olof Johansson
2007-05-15  4:33 ` [PATCH v2] pcmcia: ppc64 needs 32-bit ioaddr_t Olof Johansson
2007-05-15  7:35   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070514225731.GA4191@lixom.net \
    --to=olof@lixom$(echo .)net \
    --cc=hch@lst$(echo .)de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-pcmcia@lists$(echo .)infradead.org \
    --cc=linux@brodo$(echo .)de \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox