From: olof@lixom•net (Olof Johansson)
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>
Subject: Re: arch/powerpc/sysdev: dumping ground or only for shared drivers?
Date: Tue, 15 May 2007 17:25:29 -0500 [thread overview]
Message-ID: <20070515222529.GA14881@lixom.net> (raw)
In-Reply-To: <528646bc0705151519p5bcce91ctaaa4880cfc9e5902@mail.gmail.com>
On Tue, May 15, 2007 at 04:19:05PM -0600, Grant Likely wrote:
> On 5/15/07, Mark A. Greer <mgreer@mvista•com> wrote:
> > On Tue, May 15, 2007 at 04:06:40PM -0500, Kumar Gala wrote:
> > > If this is how we are going we should move some code from arch/
> > > powerpc/platforms into sysdev (for example the 5200 platform has its
> > > pic code and some other bits that would be candidate to move into
> > > sysdev).
> >
> > I like Paul's take as well and I don't like the idea of moving the
> > 5200 pci code, etc. to sysdev. I just can't explain why.
> >
> > But, I'll try anyway:
> >
> > The 5200 is an SoC so all the portions of that chip are tighly coupled
> > with the 5200. It doesn't make sense to put half of the 5200 code under
> > platforms and the other half under sysdev (unless the code is shared
> > with something that isn't a 5200).
>
> Actually, that's a good explaination
>
> I must agree. If there is little chance that the code will be used by
> any other platform, then don't split it up for the sake of (for
> example) putting all the pic code in the same place. I think there
> are fewer opportunities for confusion if only code that is actually
> shared goes in the shared directory. (ie. "how worried do I need to
> be about affecting other platforms when I modify this code?").
In other words, both of you agree with my original points, even though
Mark said first "I agree with Paul", and then gave the same reasons as
me for not putting non-shared stuff in sysdev. :-)
Anyway, I don't care enough to try to persuade anyone to change stance
on the question, I mostly wanted it clarified before it gets out of hand
in case it is NOT to be a dumping ground.
-Olof
next prev parent reply other threads:[~2007-05-15 22:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 20:02 [PATCH 0/13] powerpc: Add support for Marvell/mv64x60 and prpmc2800 Mark A. Greer
2007-05-10 20:04 ` [PATCH 1/13] powerpc: Add Makefile rules to wrap dts file in zImage Mark A. Greer
2007-05-10 23:29 ` David Gibson
2007-05-11 15:59 ` Mark A. Greer
2007-05-10 20:05 ` [PATCH 2/13] powerpc: Add bootwrapper support for Marvell/mv64x60 hostbridge Mark A. Greer
2007-05-10 20:05 ` [PATCH 3/13] powerpc: Add bootwrapper support for Marvell MPSC Mark A. Greer
2007-05-10 20:06 ` [PATCH 4/13] powerpc: Add bootwrapper support for Marvell/mv64x60 I2C Mark A. Greer
2007-05-10 20:06 ` [PATCH 5/13] powerpc: Add interrupt support for Marvell mv64x60 chips Mark A. Greer
2007-05-10 20:07 ` [PATCH 6/13] powerpc: Create Marvell mv64x60 MPSC (serial) platform_data Mark A. Greer
2007-05-10 20:07 ` [PATCH 7/13] powerpc: Create Marvell mv64x60 ethernet platform_data Mark A. Greer
2007-05-10 20:07 ` [PATCH 8/13] powerpc: Create Marvell mv64x60 I2C platform_data Mark A. Greer
2007-05-10 20:08 ` [PATCH 9/13] powerpc: Add Marvell mv64x60 PCI bridge support Mark A. Greer
2007-05-10 20:08 ` [PATCH 10/13] powerpc: check cache coherency of kernel vs firmware Mark A. Greer
2007-05-10 20:08 ` [PATCH 11/13] powerpc: Add DTS file for the Motorola PrPMC2800 platform Mark A. Greer
2007-05-10 21:44 ` Kumar Gala
2007-05-10 23:37 ` David Gibson
2007-05-12 11:59 ` Segher Boessenkool
2007-05-13 0:00 ` Jerry Van Baren
2007-05-13 0:21 ` Segher Boessenkool
2007-05-13 12:50 ` Jerry Van Baren
2007-05-13 14:45 ` Segher Boessenkool
2007-05-13 1:10 ` David Gibson
2007-05-10 20:09 ` [PATCH 12/13] powerpc: Add bootwrapper support for " Mark A. Greer
2007-05-10 20:09 ` [PATCH 13/13] powerpc: Add arch/powerpc support for the Motorola PrPMC2800 Mark A. Greer
2007-05-10 21:57 ` arch/powerpc/sysdev: dumping ground or only for shared drivers? Olof Johansson
2007-05-10 22:06 ` Kumar Gala
2007-05-11 1:00 ` Josh Boyer
2007-05-15 9:53 ` Christian Krafft
2007-05-10 22:40 ` David Gibson
2007-05-10 23:00 ` Mark A. Greer
2007-05-11 0:26 ` Paul Mackerras
2007-05-11 17:05 ` Linas Vepstas
2007-05-15 21:06 ` Kumar Gala
2007-05-15 22:06 ` Mark A. Greer
2007-05-15 22:19 ` Grant Likely
2007-05-15 22:25 ` Olof Johansson [this message]
2007-05-15 22:30 ` Kumar Gala
2007-05-15 23:56 ` Mark A. Greer
2007-05-16 0:32 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070515222529.GA14881@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox