public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: olof@lixom•net (Olof Johansson)
To: Michael Ellerman <michael@ellerman•id.au>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org, sfr@canb•auug.org.au
Subject: Re: [PATCH] iseries: fix CONFIG_VIOCONS/CONFIG_VT dependency
Date: Tue, 15 May 2007 23:08:00 -0500	[thread overview]
Message-ID: <20070516040800.GA17199@lixom.net> (raw)
In-Reply-To: <1179286919.4120.39.camel@concordia.ozlabs.ibm.com>

On Wed, May 16, 2007 at 01:41:59PM +1000, Michael Ellerman wrote:
> On Tue, 2007-05-15 at 14:03 -0500, Olof Johansson wrote:
> > VT already depends on !VIOCONS, but there's no restriction in the other
> > direction. This makes an allyesconfig not build.
> > 
> > Switch to a Kconfig dependency instead of a compile-time error.
> > 
> > 
> > Signed-off-by: Olof Johansson <olof@lixom•net>
> > 
> > diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
> > index 46c3a8e..e48f018 100644
> > --- a/arch/powerpc/platforms/iseries/Kconfig
> > +++ b/arch/powerpc/platforms/iseries/Kconfig
> > @@ -8,6 +8,7 @@ menu "iSeries device drivers"
> >  
> >  config VIOCONS
> >  	tristate "iSeries Virtual Console Support (Obsolete)"
> > +	depends on !VT
> >  	help
> 
> This context doesn't match linus' or the powerpc tree, I see:
> 
> config VIOCONS
>         bool "iSeries Virtual Console Support (Obsolete)"
>         depends on !HVC_ISERIES
>         default n
>         help

Boggle, I thought I did the checks in paulus' tree. It must have been
in my 2.6.21 one instead. :(

So nevermind, the above is obviously enough.


-Olof

      reply	other threads:[~2007-05-16  4:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15 19:03 [PATCH] iseries: fix CONFIG_VIOCONS/CONFIG_VT dependency Olof Johansson
2007-05-16  3:41 ` Michael Ellerman
2007-05-16  4:08   ` Olof Johansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070516040800.GA17199@lixom.net \
    --to=olof@lixom$(echo .)net \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=michael@ellerman$(echo .)id.au \
    --cc=paulus@samba$(echo .)org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox