public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle•de>
To: Geoff Levand <geoffrey.levand@am•sony.com>, linuxppc-dev@ozlabs•org
Subject: [PATCH] remove geometry support from ps3 storage driver
Date: Mon, 21 May 2007 14:53:11 +0200	[thread overview]
Message-ID: <20070521125311.GA27626@aepfle.de> (raw)


The old ps3_storage driver did not support DOS geometry, so there is no
point to start adding code for it.

Signed-off-by: Olaf Hering <olaf@aepfle•de>


Index: linux-2.6.22-rc2/drivers/block/ps3disk.c
===================================================================
--- linux-2.6.22-rc2.orig/drivers/block/ps3disk.c
+++ linux-2.6.22-rc2/drivers/block/ps3disk.c
@@ -43,10 +43,6 @@
 
 #define KERNEL_SECTOR_SIZE	512
 
-// FIXME SCSI uses H=64, S=32. Can we still repartition disks partitioned using
-//       the old driver?
-#define PS3DISK_HEADS		255
-#define PS3DISK_SECTORS		63
 
 #define PS3DISK_NAME		"ps3d%c"
 
@@ -70,21 +66,11 @@ static int ps3disk_open(struct inode *in
 	return 0;
 }
 
-static int ps3disk_getgeo(struct block_device *bdev, struct hd_geometry *geo)
-{
-	geo->heads = PS3DISK_HEADS;
-	geo->sectors = PS3DISK_SECTORS;
-	geo->cylinders = min(65535UL,
-			     get_capacity(bdev->bd_disk) /
-			     (PS3DISK_HEADS * PS3DISK_SECTORS));
-	return 0;
-}
 
 
 static struct block_device_operations ps3disk_fops = {
 	.owner		= THIS_MODULE,
 	.open		= ps3disk_open,
-	.getgeo		= ps3disk_getgeo,
 };
 
 static void ps3disk_scatter_gather(struct ps3_storage_device *dev,

             reply	other threads:[~2007-05-21 14:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21 12:53 Olaf Hering [this message]
2007-05-21 12:54 ` [PATCH] set module owner in ps3 modules Olaf Hering
2007-05-21 15:52   ` Geoff Levand
2007-05-21 14:36 ` [PATCH] remove geometry support from ps3 storage driver Geert Uytterhoeven
2007-05-21 14:39 ` Christoph Hellwig
2007-05-21 17:14   ` Olaf Hering
2007-05-29  9:15   ` Geert Uytterhoeven
2007-05-30 10:12     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070521125311.GA27626@aepfle.de \
    --to=olaf@aepfle$(echo .)de \
    --cc=geoffrey.levand@am$(echo .)sony.com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox