From: olof@lixom•net (Olof Johansson)
To: Michael Neuling <mikey@neuling•org>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] fix compile warning in pseries xics
Date: Tue, 29 May 2007 09:27:15 -0500 [thread overview]
Message-ID: <20070529142715.GA29108@lixom.net> (raw)
In-Reply-To: <4564.1180422112@neuling.org>
On Tue, May 29, 2007 at 05:01:52PM +1000, Michael Neuling wrote:
> @@ -762,11 +763,12 @@ void xics_request_IPIs(void)
> */
> set_irq_handler(ipi, handle_percpu_irq);
> if (firmware_has_feature(FW_FEATURE_LPAR))
> - request_irq(ipi, xics_ipi_action_lpar, IRQF_DISABLED,
> - "IPI", NULL);
> + rc = request_irq(ipi, xics_ipi_action_lpar, IRQF_DISABLED,
> + "IPI", NULL);
> else
> - request_irq(ipi, xics_ipi_action_direct, IRQF_DISABLED,
> - "IPI", NULL);
> + rc = request_irq(ipi, xics_ipi_action_direct, IRQF_DISABLED,
> + "IPI", NULL);
> + BUG_ON(rc);
Is this late enough during boot that you actually get useful information
out of a BUG()? It might be better to spit out an error and keep on
going if that's the case (I'm afraid I don't have hardware at hand to
test with right now).
-Olof
next prev parent reply other threads:[~2007-05-29 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 5:50 [PATCH] fix compile warning in pseries xics Michael Neuling
2007-05-29 5:52 ` Michael Ellerman
2007-05-29 7:01 ` Michael Neuling
2007-05-29 14:27 ` Olof Johansson [this message]
2007-05-30 0:28 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529142715.GA29108@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox