From: Jean-Christophe Dubois <jdubois@mc•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: linuxppc-dev@ozlabs•org, Christian Rund <crund@de•ibm.com>
Subject: Re: [RFC/PATCH 4/4] Add support for MSI on Axon-based Cell systems
Date: Tue, 5 Jun 2007 11:29:25 +0200 [thread overview]
Message-ID: <200706051129.25832.jdubois@mc.com> (raw)
In-Reply-To: <200706051116.13863.arnd@arndb.de>
On Tuesday 05 June 2007 11:16:13 Arnd Bergmann wrote:
> On Tuesday 05 June 2007, Jean-Christophe Dubois wrote:
> > On Monday 04 June 2007 15:00:05 Michael Ellerman wrote:
> > > +=A0=A0=A0=A0=A0=A0=A0pr_debug("axon_msi: initialising ...\n");
> > > +
> > > +=A0=A0=A0=A0=A0=A0=A0for_each_compatible_node(node, NULL, "ibm,axon-=
msic") {
> > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (axon_msi_setup_one(=
of_node_get(node)) =3D=3D 0)
> > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0found++;
> > > +=A0=A0=A0=A0=A0=A0=A0}
> > > +=A0=A0=A0=A0=A0=A0=A0of_node_put(node);
> >
> > 2 comments:
> >
> > 1) There is no "ibm,axon-msic" compatible property in the SLOF tree
> > provided by IBM on the CAB (or other such platforms). Therefore this co=
de
> > will not work on these platforms.
>
> Right, the firmware needs to support msi so we can use it. I guess taht's
> true for every device: If the firmware decies to hide it from us, we bett=
er
> don't try to touch it.
The SLOF firmware we have has an MSI node, just not one that=20
is "ibm,axon-msic" compatible. So nothing is hidden, quite the opposite.
> > 2) you should somehow check for the Axon version. Axon 1.1 (and prior)
> > are know to be loosing MSI/MBX interrupts (but not the data part
> > associated to them). Therefore this should be enabled only on Axon 2.1
> > (or later).
>
> Good point, thanks for mentioning it. Christian, can you confirm that the
> ibm,axon-msic node is only created on systems with axon 2.1 or later?
>
> Arnd <><
next prev parent reply other threads:[~2007-06-05 9:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 12:59 [PATCH 1/4] Split virq setup logic out into irq_setup_virq() Michael Ellerman
2007-06-04 13:00 ` [PATCH 2/4] Add irq_create_direct_mapping() Michael Ellerman
2007-06-04 22:44 ` Benjamin Herrenschmidt
2007-06-04 13:00 ` [PATCH 3/4] Add for_each_compatible_node() Michael Ellerman
2007-06-04 22:44 ` Benjamin Herrenschmidt
2007-06-04 13:00 ` [RFC/PATCH 4/4] Add support for MSI on Axon-based Cell systems Michael Ellerman
2007-06-04 17:09 ` Arnd Bergmann
2007-06-04 17:12 ` Arnd Bergmann
2007-06-08 2:53 ` Michael Ellerman
2007-06-08 8:47 ` Segher Boessenkool
2007-06-08 19:26 ` Arnd Bergmann
2007-06-08 19:36 ` Segher Boessenkool
2007-06-08 19:59 ` Segher Boessenkool
2007-06-08 20:06 ` Arnd Bergmann
2007-06-08 20:16 ` Segher Boessenkool
2007-06-12 2:32 ` Michael Ellerman
2007-06-08 20:01 ` Arnd Bergmann
2007-06-08 20:06 ` Segher Boessenkool
2007-06-12 2:30 ` Michael Ellerman
2007-06-04 22:45 ` Benjamin Herrenschmidt
2007-06-05 7:00 ` Jean-Christophe Dubois
2007-06-05 9:16 ` Arnd Bergmann
2007-06-05 9:29 ` Jean-Christophe Dubois [this message]
2007-06-05 9:30 ` Arnd Bergmann
2007-06-07 7:58 ` Michael Ellerman
2007-06-07 8:10 ` Jean-Christophe Dubois
2007-06-07 11:55 ` Benjamin Herrenschmidt
2007-06-07 12:00 ` Jean-Christophe Dubois
2007-06-05 14:12 ` Milton Miller
2007-06-06 5:19 ` Michael Ellerman
2007-06-04 22:43 ` [PATCH 1/4] Split virq setup logic out into irq_setup_virq() Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706051129.25832.jdubois@mc.com \
--to=jdubois@mc$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=crund@de$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox