From: Arnd Bergmann <arnd@arndb•de>
To: "Ming Liu" <eemingliu@hotmail•com>
Cc: domen.puncer@telargo•com, linuxppc-embedded@ozlabs•org
Subject: Re: a question on "iowrite32()"
Date: Thu, 7 Jun 2007 16:09:18 +0200 [thread overview]
Message-ID: <200706071609.19399.arnd@arndb.de> (raw)
In-Reply-To: <BAY138-F35699348E26C40AED449B3B2260@phx.gbl>
On Thursday 07 June 2007, Ming Liu wrote:
> >Since of_iomap() is rather new and hardly used by any drivers, we
> >could still redefine it so that you would use iowrite32{,be}() instead
> >of out_{be,le}32, but currently that doesn't work.
>
> So if I am correct, your suggestion is to use iowrite32be() in my device
> driver, right?
What I was saying is that iowrite32be is broken for other reasons, as it
is only defined for PCI and ISA devices and you should _not_ use it,
even if it solves the endianess problem.
What you should use is out_be32().
> However, I cannot find such a function defined in my 2.6.10 kernel.
> Isn't iowrite32be() a standard IO function like iowrite32(), or there is
> a patch to export this function?
It's a standard function, is was added less than two years ago.
You should really consider upgrading to a recent kernel version for
a number of reasons, but they are all unrelated to your current problem ;-)
Arnd <><
next prev parent reply other threads:[~2007-06-07 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 19:30 a question on "iowrite32()" Ming Liu
2007-06-07 6:20 ` Domen Puncer
2007-06-07 10:01 ` Arnd Bergmann
2007-06-07 11:20 ` Ming Liu
2007-06-07 14:09 ` Arnd Bergmann [this message]
2007-06-08 13:51 ` Ming Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706071609.19399.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=domen.puncer@telargo$(echo .)com \
--cc=eemingliu@hotmail$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox