Subject: Re: [RFC/PATCH 4/4] Add support for MSI on Axon-based Cell systems

From: Arnd Bergmann <[email-masked]>
Date: Fri, 8 Jun 2007 22:01:25 +0200

On Friday 08 June 2007, Segher Boessenkool wrote:

> >> So where is the of_node_put() done for the of_node_get()
> >> inside the loop?
> >
> > of_find_compatible_node does an of_node_put() on the device_node
> > that you pass in as the 'from' argument. In the last step, 'node'
> > is set to NULL and we put the previous element.
> 
> That wasn't my question though?

Sorry, I misread this. The of_node_get is done because we keep
a reference to the device node in the axon_msic struct. There is
no module_exit function in the driver that could clean up the
axon_msic, so we must never have an of_node_put as far as I
understand.

	Arnd <><