public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: tony@bakeyournoodle•com (Tony Breeds)
To: LinuxPPC-dev <linuxppc-dev@ozlabs•org>
Subject: [PATCH/RFC] Make certain timekeeping variables __read_mostly
Date: Wed, 20 Jun 2007 13:13:33 +1000	[thread overview]
Message-ID: <20070620031333.GP9768@bakeyournoodle.com> (raw)
In-Reply-To: <20070620020211.GO9768@bakeyournoodle.com>

On Wed, Jun 20, 2007 at 12:02:11PM +1000, Tony Breeds wrote:
 
> Also this patch makes tb_to_ns_scale and tb_to_ns_shift static for good
> measure.

While we're ate it these 3 variables can be marked __read_mostly.

Depends on previous patch.

From: Tony Breeds <tony@bakeyournoodle•com>

These really are read mostly as they're only written to in time_init()

Signed-off-by: Tony Breeds <tony@bakeyournoodle•com>

---
There looks to be other variables that can be made read_mostly, I think
that's a job for another day though (perhaps while doing the static cleanup).

 arch/powerpc/kernel/time.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Index: working/arch/powerpc/kernel/time.c
===================================================================
--- working.orig/arch/powerpc/kernel/time.c	2007-06-20 12:08:27.000000000 +1000
+++ working/arch/powerpc/kernel/time.c	2007-06-20 12:08:32.000000000 +1000
@@ -113,9 +113,9 @@ u64 ticklen_to_xs;	/* 0.64 fraction */
 DEFINE_SPINLOCK(rtc_lock);
 EXPORT_SYMBOL_GPL(rtc_lock);
 
-static u64 tb_to_ns_scale;
-static unsigned tb_to_ns_shift;
-static unsigned long boot_tb;
+static u64 tb_to_ns_scale __read_mostly;
+static unsigned tb_to_ns_shift __read_mostly;
+static unsigned long boot_tb __read_mostly;
 
 struct gettimeofday_struct do_gtod;
 

Yours Tony

  linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
  Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!

  parent reply	other threads:[~2007-06-20  3:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19  6:35 [PATCH/RFC] Modify sched_clock() to make CONFIG_PRINTK_TIME more sane Tony Breeds
2007-06-19  6:43 ` Segher Boessenkool
2007-06-19 14:53 ` Olof Johansson
2007-06-20  2:02   ` Tony Breeds
2007-06-20  2:27     ` Olof Johansson
2007-06-20  3:13     ` Tony Breeds [this message]
2007-06-20  7:41       ` [PATCH/RFC] Make certain timekeeping variables __read_mostly Geert Uytterhoeven
2007-06-21  4:41         ` Tony Breeds
2007-06-20  7:37     ` [PATCH/RFC] Modify sched_clock() to make CONFIG_PRINTK_TIME more sane Geert Uytterhoeven
2007-06-21  4:29       ` Tony Breeds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070620031333.GP9768@bakeyournoodle.com \
    --to=tony@bakeyournoodle$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox