From: Arnd Bergmann <arnd@arndb•de>
To: mita@fixstars•com
Cc: Bob Nelson <rrnelson@us•ibm.com>,
linuxppc-dev@ozlabs•org, paulus@samba•org,
Maynard Johnson <mpjohn@us•ibm.com>,
cbe-oss-dev@ozlabs•org, Carl Love <carll@us•ibm.com>
Subject: Re: [Cbe-oss-dev] [patch 2/5] Add support to OProfile for profiling Cell/B.E. SPUs
Date: Wed, 20 Jun 2007 11:35:58 +0200 [thread overview]
Message-ID: <200706201135.58985.arnd@arndb.de> (raw)
In-Reply-To: <36420.202.32.178.37.1182306728.squirrel@webmail.fixstars.com>
On Wednesday 20 June 2007, mita@fixstars•com wrote:
> > +
> > +=A0=A0=A0=A0=A0/* Allocate arrays for collecting SPU PC samples */
> > +=A0=A0=A0=A0=A0samples =3D (u32 *) kzalloc(SPUS_PER_NODE *
> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0 =A0TRACE_ARRAY_SIZE * sizeof(u32), GFP_KERNEL);
> > +
>=20
> =A0- Unnecessary cast for kzalloc().
>=20
> =A0- Allocation failure is ignored here. But there is no error handling
> =A0 =A0in timer fuction (profile_spus), too.
Right. Bob, can you make a patch to remove the case and make sure that
we never access the sample array when the allocation has failed?
Arnd <><
next prev parent reply other threads:[~2007-06-20 9:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 22:42 [patch 0/5] cell patches for 2.6.23 Arnd Bergmann
2007-06-18 22:42 ` [patch 1/5] Enable SPU switch notification to detect currently active SPU tasks Arnd Bergmann
2007-06-18 22:42 ` [patch 2/5] Add support to OProfile for profiling Cell/B.E. SPUs Arnd Bergmann
2007-06-20 2:32 ` [Cbe-oss-dev] " mita
2007-06-20 9:35 ` Arnd Bergmann [this message]
2007-06-18 22:42 ` [patch 3/5] cell: updated driver for DDR2 memory on AXON Arnd Bergmann
[not found] ` <20070619154812.GA20347@ps3linux.grid.fixstars.com>
2007-06-19 23:03 ` [Cbe-oss-dev] " Arnd Bergmann
2007-06-18 22:42 ` [patch 4/5] cell: saving spus information for kexec crash Arnd Bergmann
2007-06-18 23:58 ` [Cbe-oss-dev] " Michael Ellerman
2007-06-20 18:52 ` André Detsch
2007-06-18 22:42 ` [patch 5/5] Update cell_defconfig Arnd Bergmann
2007-06-18 23:01 ` [Cbe-oss-dev] [patch 0/5] cell patches for 2.6.23 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706201135.58985.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=carll@us$(echo .)ibm.com \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mita@fixstars$(echo .)com \
--cc=mpjohn@us$(echo .)ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=rrnelson@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox