From: tony@bakeyournoodle•com (Tony Breeds)
To: Sergei Shtylyov <sshtylyov@ru•mvista.com>
Cc: Andrew Morton <akpm@osdl•org>, Daniel Walker <dwalker@mvista•com>,
john stultz <johnstul@us•ibm.com>,
LKML <linux-kernel@vger•kernel.org>,
LinuxPPC-dev <linuxppc-dev@ozlabs•org>,
Thomas Gleixner <tglx@linutronix•de>, Ingo Molnar <mingo@elte•hu>
Subject: Re: [RFC] clocksouce implementation for powerpc
Date: Fri, 22 Jun 2007 16:10:47 +1000 [thread overview]
Message-ID: <20070622061047.GW9768@bakeyournoodle.com> (raw)
In-Reply-To: <46795B9B.2020401@ru.mvista.com>
On Wed, Jun 20, 2007 at 08:53:47PM +0400, Sergei Shtylyov wrote:
Hi Sergei,
Thanks for taking the time to look over my patch.
> I guess it's been based on the prior work by John Stultz (and me too :-)?
At some level I guess so. John did send me a patch a while ago.
> If you mean the init. part, this has been already done by me -- I've
> implemented read_persistent_clock() and got rid of xtime setting. What's
> left is to implemet update_persistent_clock() and get rid of
> timer_check_rtc()...
Actually I think that comment is redundant. and should be removed
sorry.
> Perhaps we even need to raise the rating to 300 or 400 -- according to
> what <linux/clocksource.h> says?
Sure.
> >+ .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> >+ .mask = CLOCKSOURCE_MASK(64),
> >+ .shift = 22,
>
> PPC64 has issues with the fixed shift value, see:
>
> http://patchwork.ozlabs.org/linuxppc/patch?id=11125
Thanks!
> >+ .mult = 0, /* To be filled in */
> >+ .read = NULL, /* To be filled in */
> >+ .settimeofday = NULL, /* To be filled in */
>
> I don't quite understand why not just init them right away? The values
> are fixed anyways.
Well at least mult needs to be calculated at runtime, and I prefer to
have the structure near the top of the file at which stage the
read/settimeofday functions aren't defined.
Yours Tony
linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
next prev parent reply other threads:[~2007-06-22 6:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070616101126.296384219@inhelltoy.tec.linutronix.de>
[not found] ` <20070616101637.107940593@inhelltoy.tec.linutronix.de>
[not found] ` <1182009083.11539.369.camel@imap.mvista.com>
2007-06-20 6:57 ` [RFC] clocksouce implementation for powerpc Tony Breeds
2007-06-20 14:57 ` Daniel Walker
2007-06-20 17:20 ` Sergei Shtylyov
2007-06-20 17:31 ` Thomas Gleixner
2007-06-20 18:11 ` Sergei Shtylyov
2007-06-22 6:23 ` Tony Breeds
2007-06-20 16:53 ` Sergei Shtylyov
2007-06-22 6:10 ` Tony Breeds [this message]
2007-06-22 12:42 ` Sergei Shtylyov
2007-06-20 21:06 ` john stultz
2007-06-22 6:28 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070622061047.GW9768@bakeyournoodle.com \
--to=tony@bakeyournoodle$(echo .)com \
--cc=akpm@osdl$(echo .)org \
--cc=dwalker@mvista$(echo .)com \
--cc=johnstul@us$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mingo@elte$(echo .)hu \
--cc=sshtylyov@ru$(echo .)mvista.com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox