From: Michael Buesch <mb@bu3sch•de>
To: linuxppc-dev@ozlabs•org
Cc: Christian Krafft <krafft@de•ibm.com>
Subject: Re: [patch] powerpc: sysfs fix compiler warning
Date: Sat, 23 Jun 2007 11:46:54 +0200 [thread overview]
Message-ID: <200706231146.54959.mb@bu3sch.de> (raw)
In-Reply-To: <20070622194853.72fb652a@localhost>
On Friday 22 June 2007 19:48:53 Christian Krafft wrote:
> From: Christian Krafft <krafft@de•ibm.com>
>
> This patch fixes the following compiler warning:
> arch/powerpc/kernel/sysfs.c:385: warning: ignoring return value of
> `sysfs_create_group',
>
> Signed-off-by: Christian Krafft <krafft@de•ibm.com>
>
> Index: linux-2.6.22-rc5/arch/powerpc/kernel/sysfs.c
> ===================================================================
> --- linux-2.6.22-rc5.orig/arch/powerpc/kernel/sysfs.c
> +++ linux-2.6.22-rc5/arch/powerpc/kernel/sysfs.c
> @@ -380,16 +380,23 @@ int cpu_add_sysdev_attr_group(struct att
> {
> int cpu;
> struct sys_device *sysdev;
> + int error;
>
> mutex_lock(&cpu_mutex);
>
> for_each_possible_cpu(cpu) {
> sysdev = get_cpu_sysdev(cpu);
> - sysfs_create_group(&sysdev->kobj, attrs);
> + error |= sysfs_create_group(&sysdev->kobj, attrs);
That is probably dangerous, if multiple sysfs_create_group fail
with different error codes. So it will wiggle the error codes
together.
> }
>
> + if(error)
{
> + for_each_possible_cpu(cpu) {
> + sysdev = get_cpu_sysdev(cpu);
> + sysfs_remove_group(&sysdev->kobj, attrs);
> + }
probably do something like
error = -ENOENT;
}
or some other error code here to fix it.
> +
> mutex_unlock(&cpu_mutex);
> - return 0;
> + return error;
> }
> EXPORT_SYMBOL_GPL(cpu_add_sysdev_attr_group);
>
>
>
--
Greetings Michael.
next prev parent reply other threads:[~2007-06-23 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 17:48 [patch] powerpc: sysfs fix compiler warning Christian Krafft
2007-06-22 18:38 ` Josh Boyer
2007-06-22 18:57 ` Sergei Shtylyov
2007-06-22 19:04 ` Josh Boyer
2007-06-22 19:09 ` Sergei Shtylyov
2007-06-22 19:12 ` Josh Boyer
2007-06-23 9:46 ` Michael Buesch [this message]
2007-06-25 17:07 ` Christian Krafft
-- strict thread matches above, loose matches on Subject: below --
2007-06-29 14:50 Christian Krafft
2007-06-29 14:57 ` Michael Buesch
2007-06-29 16:10 ` Christian Krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706231146.54959.mb@bu3sch.de \
--to=mb@bu3sch$(echo .)de \
--cc=krafft@de$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox