From: "Dale Farnsworth" <dale@farnsworth•org>
To: yur@emcraft•com, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix
Date: 24 Jun 2007 15:46:52 -0700 [thread overview]
Message-ID: <20070624224652.2950.qmail@farnsworth.org> (raw)
In-Reply-To: <200706241552.31483.yur@emcraft.com>
In article <200706241552.31483.yur@emcraft•com> you write:
> This patch fixes the issue of erroneously involving the
> arch/powerpc/sysdev/mv64x60*.c files into the compilation
> process for ppc- (not powerpc-) based platforms (e.g.,
> P3M750).
>
> Signed-off-by: Yuri Tikhonov <yur@emcraft•com>
>
> --
>
> diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
> index c3ce0bd..25eaa14 100644
> --- a/arch/powerpc/sysdev/Makefile
> +++ b/arch/powerpc/sysdev/Makefile
> @@ -17,7 +17,9 @@ obj-$(CONFIG_FSL_PCIE) += fsl_pcie.o
> obj-$(CONFIG_TSI108_BRIDGE) += tsi108_pci.o tsi108_dev.o
> obj-$(CONFIG_QUICC_ENGINE) += qe_lib/
> mv64x60-$(CONFIG_PCI) += mv64x60_pci.o
Shouldn't the above line also be placed inside the of following ifeq ?
> +ifeq ($(CONFIG_PPC_MERGE),y)
> obj-$(CONFIG_MV64X60) += $(mv64x60-y) mv64x60_pic.o mv64x60_dev.o
> +endif
>
> # contains only the suspend handler for time
> obj-$(CONFIG_PM) += timer.o
Thanks,
-Dale
next prev parent reply other threads:[~2007-06-24 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-24 11:52 [PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix Yuri Tikhonov
2007-06-24 22:46 ` Dale Farnsworth [this message]
2007-06-25 1:49 ` Kumar Gala
-- strict thread matches above, loose matches on Subject: below --
2007-06-25 8:47 Yuri Tikhonov
2007-06-25 9:11 ` Segher Boessenkool
2007-06-25 9:51 ` Yuri Tikhonov
2007-06-25 10:14 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070624224652.2950.qmail@farnsworth.org \
--to=dale@farnsworth$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=yur@emcraft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox